On 12/01/2018 13:18, Yemelyanenko Fyodor wrote:
Withthese modification LO is stable when autocreecting and Undo/Redo
Patchis here https://gerrit.libreoffice.org/47686
Thanks for persisting to find a good solution for this. It's much
appreciated
Regards
Matthew Francis
On 10/01/18 09:26, Miklos Vajna wrote:
> Yes, that's a known behavior, in the past I broke it and it created a
> new redline every second, that was not funny. ;-)
Can I just add, thinking with my user hat on, this can be somewhat of a
shock to the user - principle of least surprise etc and "why wh
Hi,
On Tue, Jan 09, 2018 at 05:10:00AM +, Yemelyanenko Fyodor
wrote:
> I think that the best solution for bug in question is to remove call to
> CompresRedlines from Undo/Redo. So Undo/Redo won't compress redlines and
> change indexes.
> I don't like to change CompresRedlines as it called
Hi,
On Sat, Jan 06, 2018 at 01:20:05AM +, Yemelyanenko Fyodor
wrote:
> Now I’m investigating CompresRedlines further. I think it can be
> changed so it merges only two neighbor redlines in the same node and
> not merge cross-node. Or maybe it should be completely removed, as it
> only merges
Hi,
On Thu, Jan 04, 2018 at 09:45:14AM +0800, "Matthew J. Francis"
wrote:
> I use tracked changes on a regular basis, and would much rather this be
> treated as "maybe difficult but important to get right" than "too hard, so
> don't bother"
Perhaps a middle ground is to give up undo/redo only f
On 04/01/2018 09:45, Matthew J. Francis wrote:
On 03/01/2018 17:42, Miklos Vajna wrote:
[...]
We raise a similar warning when deleting a header, you can probably
reuse that code here. And sure, clearing the undo stack instead of
crashing sounds like an improvement (especially if we ask the us
On 03/01/2018 17:42, Miklos Vajna wrote:
Hi,
On Fri, Dec 22, 2017 at 06:56:53AM +, Yemelyanenko Fyodor
wrote:
For now I see 2 possible solutions:
1. Rewrite redlining, so Show option will change how doc is viewed, but
not how it is formed (list of nodes)
2. When toggling change tracking o
Hi,
On Fri, Dec 22, 2017 at 06:56:53AM +, Yemelyanenko Fyodor
wrote:
> For now I see 2 possible solutions:
> 1. Rewrite redlining, so Show option will change how doc is viewed, but
> not how it is formed (list of nodes)
> 2. When toggling change tracking or show option ON/OFF - clean
> Und
My assumptions from email below weren't fully correct...
There is RedlineGuard class
(https://opengrok.libreoffice.org/xref/core/sw/source/core/undo/undobj.cxx#190),
instance of which is constructed just before UndoImpl called.
Constructor sets RedlineFlags to value, that been during editing, wh
