Re: Advice needed about some cppcheck reports

2012-05-30 Thread Stephan Bergmann
On 05/28/2012 06:03 PM, julien2412 wrote: [sal/osl/unx/file.cxx:1261] -> [sal/osl/unx/file.cxx:1261]: (style) Same expression on both sides of '-'. 1257 if (nSize> 0) 1258 { 1259 c^= pData[0]; 1260 pData += nSize; 1261

[PARTLY PUSHED] Re: Advice needed about some cppcheck reports

2012-05-29 Thread julien2412
Thank you Michael and Lubos for your feedback. I commited and pushed on master some elements (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=40106014f7b5c414faf087472a5ae350e683db53) I put aside for the moment : connectivity/source/drivers/mozab/MDriver.cxx:240 (we don't know yet wha

Re: Advice needed about some cppcheck reports

2012-05-29 Thread Michael Stahl
On 29/05/12 16:04, Lubos Lunak wrote: > On Tuesday 29 of May 2012, Michael Stahl wrote: >> On 28/05/12 18:03, julien2412 wrote: >>> Same thing here : >>> [sal/osl/w32/file.cxx:880] -> [sal/osl/w32/file.cxx:880]: (style) Same >>> expression on both sides of '-'. >>> 876 if (nSize > 0) >>

Re: Advice needed about some cppcheck reports

2012-05-29 Thread Lubos Lunak
On Tuesday 29 of May 2012, Michael Stahl wrote: > On 28/05/12 18:03, julien2412 wrote: > > Same thing here : > > [sal/osl/w32/file.cxx:880] -> [sal/osl/w32/file.cxx:880]: (style) Same > > expression on both sides of '-'. > > 876 if (nSize > 0) > > 877 { > > 878

Re: Advice needed about some cppcheck reports

2012-05-29 Thread Michael Stahl
On 28/05/12 18:03, julien2412 wrote: > Hello, > > Here are some cases found by cppcheck and I don't know what to do for them : > [sw/source/ui/docvw/SidebarWin.cxx:796] -> > [sw/source/ui/docvw/SidebarWin.cxx:794]: (style) Found duplicate branches > for if and else. > > 791 const SwViewOp