Re: About last cppcheck fixes

On 2015-02-17 10:45 AM, julien2412 wrote: You're right! Since it's a local var, the assignment will be useless. Your change must be the right fix. I really should think twice before posting the morning... :-) Oh no, you're definitely on to something. That code is rather fishy indeed, and

Re: About last cppcheck fixes

135 delete pConv; > 136 aConvList[nChannel-1] = DDE_FREECHANNEL; // <<<<<<<<<<<< fix > 137 > 138 return 0L; > 139 } > ... You're right! Since it's a local var, the assignment will be useless. Your change must be

Re: About last cppcheck fixes

Hi Julien On 2015-02-17 08:32 AM, Julien Nabet wrote: Hello Noel, I noticed these lines in last patch about cppcheck fixes: diff --git a/basic/source/runtime/ddectrl.cxx b/basic/source/runtime/ddectrl.cxx index 2557c9e..232008a 100644 --- a/basic/source/runtime/ddectrl.cxx