Re: -Wno-non-virtual-dtor

2012-03-15 Thread Stephan Bergmann
On 03/13/2012 02:24 PM, Stephan Bergmann wrote: [1] There might be a way around that after all, adding a non-virtual, protected destructor to the C++ classes representing UNO interfaces. Will look into that. [2] "-Wnon-virtual-dtor should't comp

Re: -Wno-non-virtual-dtor

2012-03-13 Thread Arnaud Versini
I'm also on it after the RTF patch pushed sunday ( http://cgit.freedesktop.org/libreoffice/core/commit/?id=f32fe9f5012e3ee184e1a1fca6814bee9105d8fb), the patch for WW8ResourceModel.hxx will be avaible this evening. Thanks Le 13 mars 2012 15:11, Stephan Bergmann a écrit : > On 03/13/2012 03:00

Re: -Wno-non-virtual-dtor

2012-03-13 Thread Stephan Bergmann
On 03/13/2012 03:00 PM, Lubos Lunak wrote: On Tuesday 13 of March 2012, Stephan Bergmann wrote: On 03/13/2012 11:43 AM, Tor Lillqvist wrote: Hmm, now that the reason for using -Wno-non-virtual-dtor has been documented (760e0d2d7329ca6fc00a8439715bae38becb168a ), I wonder, should we globally th

Re: -Wno-non-virtual-dtor

2012-03-13 Thread Lubos Lunak
On Tuesday 13 of March 2012, Stephan Bergmann wrote: > On 03/13/2012 11:43 AM, Tor Lillqvist wrote: > > Hmm, now that the reason for using -Wno-non-virtual-dtor has been > > documented (760e0d2d7329ca6fc00a8439715bae38becb168a ), I wonder, > > should we globally then also turn off the correspondin

Re: -Wno-non-virtual-dtor

2012-03-13 Thread Stephan Bergmann
On 03/13/2012 11:43 AM, Tor Lillqvist wrote: Hmm, now that the reason for using -Wno-non-virtual-dtor has been documented (760e0d2d7329ca6fc00a8439715bae38becb168a ), I wonder, should we globally then also turn off the corresponding MSVC warning? That would be kinda predictable (from a "the usu