Re: [Libreoffice-commits] -Werror=format-security

On 08/07/2012 04:03 PM, Bjoern Michaelsen wrote: Just like Michael and Kohei, I dont use dbgutil and find it a flawed design anyway. But you dont need enable-dbgutil(*), a simple debug=T plus SAL_LOG=+WARN will do. [...] (*) can we kill/merge that already? the only remaining valid reason for it

Re: [Libreoffice-commits] -Werror=format-security

On 08/07/2012 03:16 PM, Michael Meeks wrote: In my experience writing to stderr is synchronous; ie. fprintf (stderr, "crash\n"); *((int *)NULL) = 42; will do what you want; unless SAL_DEBUG guarantees that too it's too dangerous to be useful for me :-) SAL_DEBU

Re: [Libreoffice-commits] -Werror=format-security

On 08/07/2012 02:25 PM, Matúš Kukan wrote: SAL_DEBUG is not mentioned in the wiki AFAICS. I did not know about it and have used fprintf for the ~same reasons as Michael. I will gladly use SAL_DEBUG from now on. ...somewhat hidden at

Re: [Libreoffice-commits] -Werror=format-security

On Tue, Aug 07, 2012 at 01:53:25PM +0200, Stephan Bergmann wrote: > SAL_WARN requires an --enable-dbgutil build, but which developer doesn't do > that, anyway? Just like Michael and Kohei, I dont use dbgutil and find it a flawed design anyway. But you dont need enable-dbgutil(*), a simple debug=T

Re: [Libreoffice-commits] -Werror=format-security

On Tue, 2012-08-07 at 09:27 -0400, Kohei Yoshida wrote: > On 08/07/2012 07:53 AM, Stephan Bergmann wrote: > > No, not for SAL_DEBUG. (SAL_WARN requires an --enable-dbgutil build, > > but which developer doesn't do that, anyway? > > I don't. Obviously this will count me out of the secret LibreOf

Re: [Libreoffice-commits] -Werror=format-security

On 08/07/2012 07:53 AM, Stephan Bergmann wrote: No, not for SAL_DEBUG. (SAL_WARN requires an --enable-dbgutil build, but which developer doesn't do that, anyway? I don't. Obviously this will count me out of the secret LibreOffice elite club? Kohei -- Kohei Yoshida, LibreOffice hacker, Ca

Re: [Libreoffice-commits] -Werror=format-security

On Tue, 2012-08-07 at 13:53 +0200, Stephan Bergmann wrote: > No, not for SAL_DEBUG. (SAL_WARN requires an --enable-dbgutil build, > but which developer doesn't do that, anyway? SAL_INFO requires > SAL_LOG=+WARN+INFO, but that's on purpose, to keep the default amount of > output manageable.)

Re: [Libreoffice-commits] -Werror=format-security

On 7 August 2012 13:53, Stephan Bergmann wrote: > On 08/07/2012 01:28 PM, Michael Meeks wrote: >> >> On Tue, 2012-08-07 at 09:23 +0200, Stephan Bergmann wrote: >>> >>>Use SAL_INFO/SAL_WARN for permanent warning code (see >>>

Re: [Libreoffice-commits] -Werror=format-security

On Tuesday 07 of August 2012, Michael Meeks wrote: > On Tue, 2012-08-07 at 09:23 +0200, Stephan Bergmann wrote: > > Folks, please do not pollute the sources with fprintf in the first > > place. > > Of course that doesn't belong in master but ... > > > Use SAL_INFO/SAL_WARN for permanent war

Re: [Libreoffice-commits] -Werror=format-security

On 08/07/2012 01:28 PM, Michael Meeks wrote: On Tue, 2012-08-07 at 09:23 +0200, Stephan Bergmann wrote: Use SAL_INFO/SAL_WARN for permanent warning code (see ), and use SAL_DEBUG for temporary debug output (that the LO git

Re: [Libreoffice-commits] -Werror=format-security

On Tue, 2012-08-07 at 09:23 +0200, Stephan Bergmann wrote: > Folks, please do not pollute the sources with fprintf in the first > place. Of course that doesn't belong in master but ... > Use SAL_INFO/SAL_WARN for permanent warning code (see >

Re: [Libreoffice-commits] -Werror=format-security

On 08/06/2012 08:32 PM, Ivan Timofeev wrote: commit 770f581623ed0c7d31b9751ee789a72272b07c6c Author: Ivan Timofeev Date: Mon Aug 6 22:31:16 2012 +0400 -Werror=format-security Change-Id: Idb1267108a9eb8d08e1a14685a2f5c9a6263b46d diff --git a/sd/source/ui/remotecontrol/ImagePreparer