Hi Joseph,
Thanks for looking into this. I've done my review of the patch, and
here are my comments.
The big ones first. With this patch, we are now inheriting directly
from std::vector, which itself does not break anything, but is not
considered a good practice. The reason is that it exposes
On Thu, 2010-12-09 at 05:26 -0800, Joseph Powers wrote:
> The others are pointing to things I didn't change, so I'm a little at a
> lost as to why the errors where generated
The other one is from boost itself. I fixed it up to silence the warning
earlier today.
C.
Ok, the shadow on P is mine and is harmless. I've modified the code to remove
the warning:
void ScViewFunc::MarkAndJumpToRanges(const ScRangeList& rRanges)
{
ScViewData* pView = GetViewData();
ScDocShell* pDocSh = pView->GetDocShell();
ScRangeList aRanges(rRanges);
ScRange* p = a
On Thu, Dec 9, 2010 at 12:55 AM, Joseph Powers wrote:
> I'm converting ScRangeList from "DECLARE_LIST( ScRangeListBase, ScRange* ) "
> to "::STD::vector< ScRange*> ScRangeListBase"
> The most of the code boring and unlikely to cause issues; however, some
> areas need further review:
> sc/source/co
