Re: [Libreoffice] Duplicate code: SwDoc::SplitDoc

2011-05-23 Thread David Tardon
On Tue, May 10, 2011 at 10:17:19AM +0200, Chr. Rossmanith wrote: > Hi, > >> (what stands Stt for?) > once again: Stt means what? The answer might help to understand > what's going on in that method. Start :) I guess the original developer of the code wanted to save some typing... D.

Re: [Libreoffice] Duplicate code: SwDoc::SplitDoc

2011-05-16 Thread Michael Meeks
Hi Christina, On Tue, 2011-05-10 at 10:17 +0200, Chr. Rossmanith wrote: > There was a single code block present only in the non-outline version, > that is enclosed in "if( !bOutline )" now. Apart from that only comments > were removed in the outline version. Again - it'd be great to jus

Re: [Libreoffice] Duplicate code: SwDoc::SplitDoc

2011-05-12 Thread Chr. Rossmanith
Hi, (what stands Stt for?) If it means "start" (Nigel Hawkins suggested that) I'd suggest to rename pSttNd to pStartNd and GetSttNode to GetStartNode to get better readable code. Last but not least, I should test my changes...but how? I came across that piece of code using simian but I don

Re: [Libreoffice] Duplicate code: SwDoc::SplitDoc

2011-05-10 Thread Chr. Rossmanith
Hi, (what stands Stt for?) once again: Stt means what? The answer might help to understand what's going on in that method. It would be great; we could leave the public methods as they are now, and have a single private impl. that they call with the extra 'bool bOutline' or whatever ?

Re: [Libreoffice] Duplicate code: SwDoc::SplitDoc

2011-05-09 Thread Michael Meeks
Hi Christina, On Sun, 2011-05-08 at 23:08 +0200, Chr. Rossmanith wrote: > there are two slightly different implementations of SwDoc::SplitDoc(), Wow - that is -horrible- :-) sw/source/core/doc/docglbl.cxx takes quite some reading. Anyone cutting and pasting code like that deserves a near