Re: [Libreoffice] .: sal/inc sal/osl

2012-01-23 Thread Michael Meeks
On Mon, 2012-01-23 at 12:35 +0100, Michael Stahl wrote: > ah, yes, that's about what i expected; also, for MacOSX gcc 4.0.1 is > used, which is AFAIK the oldest one. Great. > > So, I think that it is perfectly fine to remove support for GCC 2. > > i'd be very, very surprised if anything

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-23 Thread Michael Stahl
On 23/01/12 10:03, Petr Mladek wrote: > Michael Meeks píše v Pá 20. 01. 2012 v 17:34 +: >> On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: +#if defined(__GNUC__) && (__GNUC__ < 3) +struct ::stat a_stat, b_stat; +#else +struct stat a_stat, b_stat; +#endif

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-23 Thread Petr Mladek
Michael Meeks píše v Pá 20. 01. 2012 v 17:34 +: > On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: > > > +#if defined(__GNUC__) && (__GNUC__ < 3) > > > +struct ::stat a_stat, b_stat; > > > +#else > > > +struct stat a_stat, b_stat; > > > +#endif > > > > do we really need to have

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-20 Thread Michael Meeks
On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: > > +#if defined(__GNUC__) && (__GNUC__ < 3) > > +struct ::stat a_stat, b_stat; > > +#else > > +struct stat a_stat, b_stat; > > +#endif > > do we really need to have ifdefs for GCC 2 in LO? Probably not :-) I just re-used wh

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-20 Thread Michael Stahl
On 19/01/12 18:04, Michael Meeks wrote: > sal/inc/osl/detail/file.h |6 -- > sal/osl/unx/file_stat.cxx | 20 ++-- > 2 files changed, 10 insertions(+), 16 deletions(-) > > New commits: > commit c5d4f4967e5d9d0220fadf3f313ddc35002cdf27 > Author: Michael Meeks > Date: Th