Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread David Tardon
On Tue, Dec 07, 2010 at 12:39:19PM +, Michael Meeks wrote: > Hi David, > > On Tue, 2010-12-07 at 10:54 +0100, David Tardon wrote: > > > I think the simplest thing here is to run SessionManagerClient::open > > > when initializing the quickstarter (the function is exported, so there > > > should

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread Michael Meeks
Hi David, On Tue, 2010-12-07 at 10:54 +0100, David Tardon wrote: > > I think the simplest thing here is to run SessionManagerClient::open > > when initializing the quickstarter (the function is exported, so there > > should be no problem with that), but there might be a cleaner solution. > > What

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread David Tardon
> The problem is that SessionManagerClient is only initialized with the > first sal frame (IOW, GtkSalFrame::Show calls > SessionManagerClient::open). Obviously, if there has never been any > frame opened, which, I suppose, happens in a lot of cases, this hadn't > happened. So the app is not aware

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread Caolán McNamara
On Tue, 2010-12-07 at 09:53 +0100, David Tardon wrote: > Bah, the header where it's declared is not public :( Make it public then :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreo

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread David Tardon
On Tue, Dec 07, 2010 at 09:34:52AM +0100, David Tardon wrote: > The problem is that SessionManagerClient is only initialized with the > first sal frame (IOW, GtkSalFrame::Show calls > SessionManagerClient::open). Obviously, if there has never been any > frame opened, which, I suppose, happens in a

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-07 Thread David Tardon
Hi, Michael, On Mon, Dec 06, 2010 at 03:59:17PM +, Michael Meeks wrote: > Hi David, > > On Mon, 2010-12-06 at 15:18 +0100, David Tardon wrote: > > On Mon, Dec 06, 2010 at 02:08:36PM +, Michael Meeks wrote: > > > Really ? as soon as the X server dies, we'll get all manner of XErrors > >

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-06 Thread Norbert Thiebaud
On Mon, Dec 6, 2010 at 10:12 AM, Christopher Backhouse wrote: ... > > Chris > > PS - is there a git commit notification list I can subscribe to? The git web > interface is a royal pain to navigate. http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits > > ___

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-06 Thread Christopher Backhouse
On 06/12/2010 15:47, Michael Meeks wrote: Yes - it's a pain; hence doing it for you. I was thinking of more exciting fun / new things :-) Thanks. We rather need someone clueful to tackle the problem of the flat ODF / XML export - if you're interested ? http://wiki.documentfoundation.

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-06 Thread Michael Meeks
Hi David, On Mon, 2010-12-06 at 15:18 +0100, David Tardon wrote: > On Mon, Dec 06, 2010 at 02:08:36PM +, Michael Meeks wrote: > > Really ? as soon as the X server dies, we'll get all manner of XErrors > > that will kill us nastily; I don't see a feature there, but perhaps I'm > > missing i

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-06 Thread Michael Meeks
On Mon, 2010-12-06 at 15:01 +, Christopher Backhouse wrote: > I have locally a check against the gtk version (the highest version Heh - sorry pardon; I just added that to configure - we disable the gtk + systray where we know it won't work there; and that also fixes the scp2 issues y

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg (Spam Message)

2010-12-06 Thread Michael Meeks
On Mon, 2010-12-06 at 15:24 +0100, Sebastian Spaeth wrote: > Perhaps removing the bundled libegg project and disable copying it in > our install package? :-) Already done :-) Regards, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-06 Thread Christopher Backhouse
On 06/12/2010 14:08, Michael Meeks wrote: I gave it a reasonble test, of all the combinations I could think of [ though not session exit ], and I've pushed it. Cool, thanks. On 06/12/2010 14:08, Michael Meeks wrote: I guess, since SLED10 ships with gtk+ 2.8.11 or something cra

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-06 Thread Sebastian Spaeth
On Mon, 06 Dec 2010 14:08:36 +, Michael Meeks wrote: > Thanks so much for this Christopher ! what is your next planned > feat ? :-) Perhaps removing the bundled libegg project and disable copying it in our install package? :-) Sebastian pgpfAQ227kXmt.pgp Description: PGP signature ___

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-06 Thread David Tardon
On Mon, Dec 06, 2010 at 02:08:36PM +, Michael Meeks wrote: > > On Mon, 2010-12-06 at 08:30 +0100, David Tardon wrote: > > The current impl. shutdowns LibO when desktop session is ended. Unless > > I'm missing something obvious, the new impl. cannot do that... > > Really ? as soon as the

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-06 Thread Michael Meeks
On Mon, 2010-12-06 at 08:30 +0100, David Tardon wrote: > The current impl. shutdowns LibO when desktop session is ended. Unless > I'm missing something obvious, the new impl. cannot do that... Really ? as soon as the X server dies, we'll get all manner of XErrors that will kill us nastily

Re: [Libreoffice] [PATCH] Use GtkStatusIcon instead of libegg

2010-12-05 Thread David Tardon
On Sun, Dec 05, 2010 at 02:09:05PM +, Christopher Backhouse wrote: > Hi, > > This is item 3.17 in the easy hacks list. > Seems to work fine here. I can turn the quickstarter on and off and > launch things from it. > > The code is simplified a little from the libegg version (partially > becaus