Re: [Libreoffice] [PATCH] Remove most of dead code in libs-core

2011-03-14 Thread Caolán McNamara
On Tue, 2011-03-08 at 21:06 +0100, Xisco Faulí wrote: > Hello, > > > I've been working on removing dead code in libs-core for a while ago. > I'd say libs-core it's now 98-99% dead code free. I'm reading through these at the moment, so taking a lock on review, there's quite a few of them ;-) I'm

Re: [Libreoffice] [PATCH] Remove most of dead code in libs-core

2011-03-10 Thread Christina Roßmanith
Hi, I'm having a look at your patch files. The first thing to mention is that "whitespace-only changes" should be avoided. The second thing: 12000 lines for a single patch file is too long. You should split them into pieces that reviewing a single patch can be done in a reasonable time. You'