Hi Anurag,
On Tue, 2011-08-23 at 20:25 +0530, Anurag Jain wrote:
> Hello Kohei,
>
> This is a fix to some of the things you mentioned in last patch.
> Setting the paper size inside the Resize() of ScMultiTextWnd solves
> two issues
>
> 1: Prevents premature wrapping which was happening before.
>
Hi Anurag,
On Sat, 2011-08-20 at 23:16 +0530, Anurag Jain wrote:
> Hello Kohei,
>
> I've Worked around ScrollBar and Made it appear. But still not able to
> get the event handling thing working. Also I've improved some previous
> code which handles sizing and positioning of button and other
> con
Hi Anurag,
I pushed your patch to the feature branch. I think I noticed is that
your commit name is all caps ANURAG JAIN. Could you fix that to
properly capped name for your future patches?
On Thu, 2011-08-04 at 13:43 +0530, Anurag Jain wrote:
> I'll implement these things after returning from
Hi Anurag,
On Mon, 2011-07-11 at 08:28 +0530, Anurag Jain wrote:
> 1: Setting the proper output area when the toggling happens. I've
> tried working on it but was not able to get vertical offset proper
> when in multiline mode. So need to look more into its mathematics.
>
> 2: As Noel mentioned
On 05/07/11 03:52, Anurag Jain wrote:
As of now there are might be some printf's lying around so ignore them
as of now.
Awaiting your feedback on this.
Ok, here goes
1) ScInputBarGroup::ScInputBarGroup()
In the initialization list,
bIsMultiLine( this ) is wrong surely, bIsMultiLine is of
On 05/07/11 03:52, Anurag Jain wrote:
Hello Noel,
As you asked I'm sending a patch here with most of the changes
incorporated. I've done total rework again and made a bit more
modular, removed unnecessary things and now it look way better than
what i was getting yesterday. Please have a look bef
Hello Noel,
As you asked I'm sending a patch here with most of the changes
incorporated. I've done total rework again and made a bit more
modular, removed unnecessary things and now it look way better than
what i was getting yesterday. Please have a look before you make
changes on you end and if y
On 04/07/11 11:29, Anurag Jain wrote:
Hello Noel,
I'm sending the inputwin.cxx with the changes I've made in
ScInputBargroup. Do not push it as of now. I'd be making some more
changes as mentioned in above mail before it can be pushed.
I guess it really isn't usable without a header file :-( I r
Hello Noel,
Yes I have made some changes as you mentioned this weekend. There are
certain thing I'm not getting properly.
1: I'm able to toggle the height of ScMultiBar and ScInputBarGroup on
button click. But the increment happens inside the ScInputWindow i.e.
the excess window size do not appea
Hi Anurag,
As discussed on IRC I had hoped to see the patch you promised to send.
The one that rename's your class, restores ScTextWnd and removes the
unnecessary changes and does some cleanup of the existing code, is there
some problem? everything ok? I need those changes to integrate your co
Hi Anurag
On 26/06/11 18:23, Anurag Jain wrote:
Hello Noel,
On Fri, Jun 24, 2011 at 7:53 PM, Noel Power wrote:
[...]
I'm sending the fix patch here which calculates the height and width
of the ScInputbarGroup and makes the border invisible.
great, thanks for that, more comments about the pat
Hello Noel,
On Fri, Jun 24, 2011 at 7:53 PM, Noel Power wrote:
> Hi Anurag
> On 22/06/11 15:51, Anurag Jain wrote:
>>
>> Hi Noel,
>>
>> Resending the patch again along with the source files here.
>
> as mentioned on Wed on iRC I pushed the patch to the feature branch. I had
> hoped to see the lat
Hi Anurag
On 22/06/11 15:51, Anurag Jain wrote:
Hi Noel,
Resending the patch again along with the source files here.
as mentioned on Wed on iRC I pushed the patch to the feature branch. I
had hoped to see the latest changes you made to correct the control size
problem that I identified that wa
Hi Anurag
On 22/06/11 05:20, Anurag Jain wrote:
Hi Noel,
Actually the problem started from not doing a git pull on my end after
Kohei pushing my patch (created using git diff) as I went on making
changes. In order to resolve this I ran git stash; git pull; and then
git stash pop; And I made some
Hi Noel,
Actually the problem started from not doing a git pull on my end after
Kohei pushing my patch (created using git diff) as I went on making
changes. In order to resolve this I ran git stash; git pull; and then
git stash pop; And I made some more changes and sent you the same
patch generate
Hi Anurag
On 21/06/11 18:59, Anurag Jain wrote:
Hi Noel,
Please review the patch I'm sending here. I did not have luck getting
the control shown up. Please guide me what I'm missing ?
Thanks and regards
Sorry I think you need to redo the patch, it doesn't apply for me ( or
at least the hunks t
On Tue, 2011-06-07 at 07:27 +0530, Anurag Jain wrote:
> Hello Kohei,
>
> In this patch I've removed the hard coded values for the height
Yup. This one looks much better. Pushed to your feature branch. :-)
BTW, it would be nice to have you pull the new changes from the
repository so that your n
Hi Kohei,
Have a look into this. I've fixed the display problem with the j and g letters.
On Tue, Jun 7, 2011 at 12:57 AM, Kohei Yoshida wrote:
> Hi Anurag,
>
> On Tue, 2011-06-07 at 00:15 +0530, Anurag Jain wrote:
>> Hello Kohei,
>>
>> I was able to figure out how to make the text appear proper
Hi Anurag,
On Tue, 2011-06-07 at 00:15 +0530, Anurag Jain wrote:
> Hello Kohei,
>
> I was able to figure out how to make the text appear properly in the
> inputbar when in single line mode. I'm sending my patch over here.
> Please have a look into it and let me know about further improvements
> t
On Thu, 2011-05-12 at 23:27 -0400, Kohei Yoshida wrote:
> On Fri, 2011-05-13 at 03:53 +0530, Anurag Jain wrote:
> > Hello There,
> >
> > I'm posting here the git diff of the work I've done till now.
> > @Kohei Since I do not want to disturb my master branch I'm here
> > pasting the diff only. Plea
On Fri, 2011-05-13 at 03:53 +0530, Anurag Jain wrote:
> Hello There,
>
> I'm posting here the git diff of the work I've done till now.
> @Kohei Since I do not want to disturb my master branch I'm here
> pasting the diff only. Please create a feature branch and apply it, so
> that I can clone that
21 matches
Mail list logo
