I have zero insight into that area of the code, but from what I gather:
GrammarCheckingIterator::GetSuggestedEndOfSentence(rText, ...) -- where
rText apparently is one single paragraph -- used to be convoluted code
that always returns rText.getLength() for the last few years, whether
that chan
Hi all,
what's the supposed regression, exactly? Do we have only sentences as
segmented by LO? This would be a serious drawback as ICU methods are less
than perfect, and our results are much more reliable (the BreakIterator
simply uses a static list of abbreviations which is a vast simplification
Hi,
If I right know, that was an intended change from the original author,
Thomas Lange, supported by the contributors, eg. Marcin Miłkowski and
Daniel Naber, for the real needs, better sentence boundary
disambiguation and grammar checking by LanguageTool and other grammar
checker components. So t
Caolán McNamara wrote
> do you get the pre LO 4 behaviour ?
Probably.
With LO 3, in doProofreading:
- nStartOfSentencePos was always the beginning of the paragraph (=0)
- nSuggestedSentenceEndPos was always the end of the paragraph (=length of
rText)
And each paragraph was passed once to the GC.
On Sat, 2013-03-02 at 04:09 -0800, Olivier R. wrote:
> I bibisected from scratch again, on Linux Mint. I got no crash at all.
Looking at the log, (but without testing anything myself) the likely
relevant changes are...
c0f865c9b5a34b272c9e0b22d18969554265914a on
linguistic/source/gciterator.cxx w
I bibisected from scratch again, on Linux Mint. I got no crash at all.
Result:
20bcb05266724b495f909e6bdc5b253b15515e7d is the first bad commit
commit 20bcb05266724b495f909e6bdc5b253b15515e7d
Author: Bjoern Michaelsen
Date: Mon Dec 10 23:37:31 2012 +
source-hash-f260c656da4457c5d87c16
On Thursday 28 of February 2013, Olivier R. wrote:
> Stephan Bergmann-2 wrote
>
> > How exactly do you launch LO? If by calling install/program/soffice.bin
> > instead of install/program/soffice then the behavior is expected
> > (soffice starts and controls soffice.bin, which needs to re-start on
Stephan Bergmann-2 wrote
> How exactly do you launch LO? If by calling install/program/soffice.bin
> instead of install/program/soffice then the behavior is expected
> (soffice starts and controls soffice.bin, which needs to re-start on
> first start after any upgrade to cater for potential cha
On 02/27/2013 06:58 PM, Olivier R. wrote:
But I have to say that I am not really sure this result can be trusted. For
each times I bibisect, LO didn't launch at the first try, only on the second
try.
How exactly do you launch LO? If by calling install/program/soffice.bin
instead of install/pr
Caolán McNamara wrote
> Can you supply a simple to run test-kit that could be used by someone
> else to bibisect the change ? An easy to test/run macro/script/hack that
> works in 3.6 and fails in 4.0.
>
> C.
I bibisected myself, then I got this result:
266724b495f909e6bdc5b253b15515e7d is the f
On Sat, 2013-02-23 at 13:19 -0800, Olivier R. wrote:
> Hello Caolan,
>
>
> Caolán McNamara wrote
> > No idea, IMO it would be worth bibisecting this to find where it changed
> > to re-examine if it was intentional or not. Would then likely be a good
> > candidate for a unit test to lock in whiche
Hello Caolan,
Caolán McNamara wrote
> No idea, IMO it would be worth bibisecting this to find where it changed
> to re-examine if it was intentional or not. Would then likely be a good
> candidate for a unit test to lock in whichever is the right behaviour.
If someone did this intentionally he s
On Sun, 2013-01-20 at 08:25 -0800, Olivier R. wrote:
> With LibreOffice 4, each paragraph of a text is passed several times to this
> function in the parameter aText, and the parameters nStartOfSentencePosition
> and nSuggestedBehindEndOfSentencePosition are the beginning and the end of
> each sent
13 matches
Mail list logo
