On Fri, Jun 22, 2012 at 01:13:50PM +0200, Lionel Elie Mamane wrote:
> No. When I have some free / floating time, I hunt for low-hanging
> fruit in the review queue (patches I can review without understanding
> the area), so that the "big" reviewers can focus on the more
> complicated reviews. So r
On Thu, Jun 21, 2012 at 10:06:28AM +0200, Bjoern Michaelsen wrote:
> On Thu, Jun 21, 2012 at 07:53:42AM +0200, Lionel Elie Mamane wrote:
>> As I review very few patches, keeping me happy in this respect is
>> probably not high priority, except maybe as a long tail argument (if
>> we have 100 commi
Hi Kendy,
On Thu, Jun 21, 2012 at 11:25:18AM +0200, Jan Holesovsky wrote:
> I believe this way we might keep both camps ("everything into ML" like
> me, and "only discussions on the ML" like Bjoern) happy - because the
> people who want to have only discussions on the ML would be able to
> filter
Hi,
On 2012-06-21 at 10:55 +0200, d.ostrov...@idaia.de wrote:
> > Something like:
> > - a short dialy digest of changes to keep reviewers in the loop
> > - _one_ mail once a change goes in with all the comments/revisions and
> > back-and-forth for this change in context in it
> >
> > or somethi
Zitat von Bjoern Michaelsen :
Something like:
- a short dialy digest of changes to keep reviewers in the loop
- _one_ mail once a change goes in with all the comments/revisions and
back-and-forth for this change in context in it
or something completely different? We might get rid of the firs
Hi Winfried!
On Thu, Jun 21, 2012 at 08:26:09AM +0200, Winfried Donkers wrote:
> Not wanting to interfere, just to provide some feedback:
> being a volunteer and being on the brink of newcomer and not-quite newcomer,
> the mailing list gives me a lot of information. Comments on submitted patches
>
On Thu, Jun 21, 2012 at 07:53:42AM +0200, Lionel Elie Mamane wrote:
> What I fear the most in that is that I have no way to mark a patch as
> "I won't review it, not my area / I don't know / don't understand /
> ...". With publish-to-ML, I just mark the post / whole thread as
> "read". With gerrit,
On Thu, Jun 21, 2012 at 02:10:05AM -0500, Norbert Thiebaud wrote:
> On Thu, Jun 21, 2012 at 12:53 AM, Lionel Elie Mamane wrote:
>> What I fear the most in that is that I have no way to mark a patch as
>> "I won't review it, not my area / I don't know / don't understand /
>> ...".
> No but...
> 1
On Thu, Jun 21, 2012 at 12:53 AM, Lionel Elie Mamane wrote:
>
> What I fear the most in that is that I have no way to mark a patch as
> "I won't review it, not my area / I don't know / don't understand /
> ...".
No but...
1/ you can 'star' patch
2/ patch are presented in reverse chronological ord
On 06/21/2012 08:08 AM, Norbert Thiebaud wrote:
On Wed, Jun 20, 2012 at 11:57 PM, David Ostrovsky
wrote:
[...]
As I explained on IRC: someone that _is_ a Committer can do some
modification and still push the patch with you as author and him as
commiter (git allow that, if we used svn like som
On 06/20/2012 10:27 PM, David Ostrovsky wrote:
On 20.06.2012 14:11, Stephan Bergmann wrote:
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
I got one question with gerrit so far:
how can other people contribute code snippet into foreign gerrit patch
(so called extend it)?
During my work on gbuil
> > Still, this removes the comments from many people's (potential) sight.
> > The IMO big advantage of the "everything on a single mailing list"
> > approach is that everybody is forced ;) to see everything (modulo
> > information overload)
>
> So, IMHO that advantage not only has its drawbacks (
On Wed, Jun 20, 2012 at 11:57 PM, David Ostrovsky
wrote:
> While claiming other people's work to be your own may be not a problem in
> other contries,
> here in gemany it is: in fact minister of defence and other politicians
> stepped down for doing exactly that (copy/paste parts of their disserta
On Wed, Jun 20, 2012 at 02:34:13PM +0200, Bjoern Michaelsen wrote:
> On Wed, Jun 20, 2012 at 02:11:31PM +0200, Stephan Bergmann wrote:
>> Still, this removes the comments from many people's (potential)
>> sight. The IMO big advantage of the "everything on a single mailing
>> list" approach is that
On 20.06.2012 22:47, Norbert Thiebaud wrote:
On Wed, Jun 20, 2012 at 3:27 PM, David Ostrovsky wrote:
AFAIKs it can not be solved with gerrit: only i can change my gerrit
patch/change.
really ?
I just did exactly that onhttps://gerrit.libreoffice.org/#/c/229/
Wow! no bad, not bad, but now this
foreword: please trim the quotation when you reply...
On Wed, Jun 20, 2012 at 3:27 PM, David Ostrovsky wrote:
>
> May be I'm missing something obvious here, but how would it change the
> things if you would use command line instead of web UI?
Choice is a great thing.
> AFAIKs it can not be sol
On 20.06.2012 14:11, Stephan Bergmann wrote:
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
On 19.06.2012 19:24, Petr Mladek wrote:
Sounds good but how many people would know about the comments? How hard
would be to find them?
https://gerrit.libreoffice.org/#/c/179/4/
(may be you need to login
On Wed, Jun 20, 2012 at 02:11:31PM +0200, Stephan Bergmann wrote:
> Still, this removes the comments from many people's (potential)
> sight. The IMO big advantage of the "everything on a single mailing
> list" approach is that everybody is forced ;) to see everything
> (modulo information overload)
On 06/19/2012 09:32 PM, David Ostrovsky wrote:
On 19.06.2012 19:24, Petr Mladek wrote:
Sounds good but how many people would know about the comments? How hard
would be to find them?
https://gerrit.libreoffice.org/#/c/179/4/
(may be you need to login into gerrit with your openId)
You can see it
Hi Tor,
On Tue, Jun 19, 2012 at 10:14:27PM +0300, Tor Lillqvist wrote:
> But if the intent is that *all* changes are to go through gerrit,
Its not. As said repeatedly on this thread already, everyone who has an fd.o
account will be able to continue to push to master. However, the hope is that
the
Hi Petr, all,
i am using gerrit for a while now and gathered some experience with it
already and would like
to share it with you.
On 19.06.2012 19:24, Petr Mladek wrote:
Bjoern Michaelsen píše v Út 19. 06. 2012 v 18:40 +0200:
Hi Petr,
On Tue, Jun 19, 2012 at 06:14:18PM +0200, Petr Mladek wr
I find it peculiar that in the discussion here people keep talking
about patches, as if gerrit was only a "patch" review tool. At least I
understand "patch" to mean a relatively local change to the code in
order to fix some specific bug. But if the intent is that *all*
changes are to go through ger
Hi,
On Tue, Jun 19, 2012 at 07:24:30PM +0200, Petr Mladek wrote:
> Sure but who will be the reviewer? The mailing list has the advantage
> that people step in when they are interested. It helps to balance the
> workload. Also it is very open for new reviewers. I am afraid that
> gerrit could make
Bjoern Michaelsen píše v Út 19. 06. 2012 v 18:40 +0200:
> Hi Petr,
>
> On Tue, Jun 19, 2012 at 06:14:18PM +0200, Petr Mladek wrote:
> > Ah, this bug is about a daily digest. I think that we first need to
> > decide how much we want to modify the current work flow. Do we want to
> > really move mos
Hi Petr,
On Tue, Jun 19, 2012 at 06:14:18PM +0200, Petr Mladek wrote:
> Ah, this bug is about a daily digest. I think that we first need to
> decide how much we want to modify the current work flow. Do we want to
> really move most discussions from the mailing list to gerrit?
IMHO yes, they are n
Bjoern Michaelsen píše v Út 19. 06. 2012 v 13:38 +0200:
> On Tue, Jun 19, 2012 at 11:13:45AM +0200, Petr Mladek wrote:
> > It means that gerrit should be able to detect patches for review on the
> > mailing list, integrate them, and make them ready for review.
> >
> > My expectation would be that
On Tue, Jun 19, 2012 at 11:13:45AM +0200, Petr Mladek wrote:
> It means that gerrit should be able to detect patches for review on the
> mailing list, integrate them, and make them ready for review.
>
> My expectation would be that it sends a replay to the mailing list with
> a link to diff, link
Bjoern Michaelsen píše v Po 18. 06. 2012 v 12:09 +0200:
> Hi all,
>
> with:
>
> http://sweetshark.livejournal.com/13298.html
>
> gerrit is documented and ready to go.
Ah, there are several strange and long commands.
Also I miss the cooperation with the mailing list. I remember that the
main re
28 matches
Mail list logo
