Re: Questions about Domain Mapper

2013-11-25 Thread Miklos Vajna
Hi Adam, On Sun, Nov 24, 2013 at 06:06:06PM +0200, Adam Fyne wrote: > I think I was misunderstood. > I think you thought I was asking : "I need to add each property like > bold\italic\underline separatly to the RedlineParams". > What I actually meant to ask was: > Currently there are a lot of XM

Re: Questions about Domain Mapper

2013-11-24 Thread Adam Fyne
*And some more elaboration on that:* I just checked a simple DOCX that had some text in 'bold' and 'italic'. I then turned ON the 'track changes' and removed the 'bold' and 'italic'. When I round-tripped the DOCX through LO - the outputted file *had* the 'bold' and 'italic' turned on. This means th

Re: Questions about Domain Mapper

2013-11-24 Thread Adam Fyne
Hi Miklos, On Thu, Nov 21, 2013 at 10:55 AM, Miklos Vajna wrote: > Hi Adam, > > > When I look at the code that processes these nodes - I see that all of > > these parameters > > are being processed here > > > http://opengrok.libreoffice.org/xref/core/writerfilter/source/dmapper/DomainMapper.cxx#

Re: Questions about Domain Mapper

2013-11-22 Thread Miklos Vajna
Hi Adam, On Thu, Nov 21, 2013 at 11:11:47AM +0200, Adam Fyne wrote: > In each mail you say "hope this helps", so in each reply I will continue > saying : "yes, it really helps a lot!" :-) Glad to hear that. If possible, please try not to remove the mailing list from the CC, this helps to have t

Re: Questions about Domain Mapper

2013-11-21 Thread Miklos Vajna
Hi Adam, On Wed, Nov 20, 2013 at 05:49:59PM +0200, Adam Fyne wrote: > > A redline may contain multiple runs or paragraphs. When the redline > > starts, it's added to m_aRedlines, and once it's finished, it gets > > removed. > > If a redline can contain 10 paragraphs inside of it - what's the lo

Re: Questions about Domain Mapper

2013-11-20 Thread Miklos Vajna
Hi Adam, On Wed, Nov 20, 2013 at 02:42:25PM +0200, Adam Fyne wrote: > 1\ 'DomainMapper_Impl::appendTextPortion' creates a variable called > 'xTextRange' but doesn't do anything with it. > How does that end up in the Writer core objects? The insertTextPortion() or appendTextPortion() UNO calls i