Re: Question on dubious code

2013-10-17 Thread Matteo Casalin
On 10/07/2013 03:35 PM, Caolán McNamara wrote: On Sat, 2013-10-05 at 19:45 +0200, Matteo Casalin wrote: looks wrong to me since aUserData cannot start with both aProt and ".". I had a look at older revisions, but the logic remains the same at least from when it was integrated in 2005 with commi

Re: Question on dubious code

2013-10-07 Thread Michael Stahl
On 05/10/13 19:45, Matteo Casalin wrote: > Hi all, > in sw/source/core/graphic/ndgrf.cxx I stepped into the following > code in function lcl_GetStreamStorageNames (this is after OUString > conversion): > > const OUString aProt( "vnd.sun.star.Package:" ); > if (sUserData.startsWith

Re: Question on dubious code

2013-10-07 Thread Caolán McNamara
On Sat, 2013-10-05 at 19:45 +0200, Matteo Casalin wrote: > looks wrong to me since aUserData cannot start with both aProt and > ".". I had a look at older revisions, but the logic remains the same at > least from when it was integrated in 2005 with commit > 4fdb2d2cb198e7ea85d129d96a6c26b50

Question on dubious code

2013-10-05 Thread Matteo Casalin
Hi all, in sw/source/core/graphic/ndgrf.cxx I stepped into the following code in function lcl_GetStreamStorageNames (this is after OUString conversion): const OUString aProt( "vnd.sun.star.Package:" ); if (sUserData.startsWith(aProt)) { // 6.0 (XML) Package cons