Re: Problems with data labels in charts

2020-08-29 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 18-Aug-20 um 09:19: Given it's there since 2014, I think there is benefit in not breaking that. I would rather add the remaining missing LabelFoo properties and keep the existing API working than the other way around. Besides missing unit tests, import is fi

Re: Problems with data labels in charts

2020-08-22 Thread Regina Henschel
Hi Miklos, hi all, Miklos Vajna schrieb am 18-Aug-20 um 09:19: Hi Regina, On Mon, Aug 17, 2020 at 08:19:37PM +0200, Regina Henschel wrote: So you suggest to keep the internal structure? That would mean, we will get about 18 additional "LabelFoo" properties over the time for the still missin

Re: Problems with data labels in charts

2020-08-18 Thread Miklos Vajna
Hi Regina, On Mon, Aug 17, 2020 at 08:19:37PM +0200, Regina Henschel wrote: > So you suggest to keep the internal structure? > > That would mean, we will get about 18 additional "LabelFoo" properties over > the time for the still missing fill and line properties. That is indeed some cost to be

Re: Problems with data labels in charts

2020-08-17 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 17-Aug-20 um 10:08: Hi Regina, On Sun, Aug 16, 2020 at 05:27:07PM +0200, Regina Henschel wrote: So there are discrepancies between what LibreOffice writes and reads and what exists in ODF. What to do? Regarding data label fill style, I think Gulsah added

Re: Problems with data labels in charts

2020-08-17 Thread Miklos Vajna
Hi Regina, On Sun, Aug 16, 2020 at 05:27:07PM +0200, Regina Henschel wrote: > So there are discrepancies between what LibreOffice writes and reads and > what exists in ODF. What to do? Regarding data label fill style, I think Gulsah added that recently in commit 603df08a1e0211099ce2cf258cfe64a7

Problems with data labels in charts

2020-08-16 Thread Regina Henschel
Hi all, as far as I understand, we have currently this situation: Graphic properties -- A data label is created as css.drawing.TextShape and as such it can have FillProperties, LineProperties and ShadowProperties. In ODF, a data label is a element and its style can have gr