Re: Problems with OutputDevice

2021-04-11 Thread Chris Sherlock
On 1 Jan 2021, at 4:44 am, Chris Sherlock wrote: > > Parallel task: decouple metafile recording from drawing functionality > > My plan for this is to do the following: > > 1. I create a RenderContext2 class which OutputDevice derives from > 2. Carefully and gradually move the drawing code into

Re: Problems with OutputDevice

2021-01-04 Thread Luboš Luňák
On Wednesday 30 of December 2020, Chris Sherlock wrote: > I propose that it might be worthwhile moving the fallback code back into > SalGraphics itself. Any new primitive functions need to have fallback code, > or we mandate that any new backends must implement the primitive function. > My POC can

Re: Problems with OutputDevice

2021-01-02 Thread Thorsten Behrens
Hi Chris, Chris Sherlock wrote: > I’m assuming that we obviously rely on GDI+ now? > Yeah, but it's hopefully on the way out with skia shaping up. > What is your opinion of the fallback code being placed in SalGraphics? > Makes sense to me, to consolidate fallbacks into one place. Just be aware

Re: Problems with OutputDevice

2021-01-01 Thread Chris Sherlock
> On 2 Jan 2021, at 9:48 am, Thorsten Behrens wrote: > > Chris Sherlock wrote: >> OutputDevice relies of VirtualDevice for alpha blending >> >> What can I say? It’s an extraordinary hack and has been that way for >> a long time. >> > Rooted in history, too. I did that hack many years ago, as

Re: Problems with OutputDevice

2021-01-01 Thread Thorsten Behrens
Chris Sherlock wrote: > OutputDevice relies of VirtualDevice for alpha blending > > What can I say? It’s an extraordinary hack and has been that way for > a long time. > Rooted in history, too. I did that hack many years ago, as Win32 GDI had no good way to render into ARGB surfaces - and GDI+ was

Re: Problems with OutputDevice

2021-01-01 Thread Thorsten Behrens
Hi Chris, first off - great to see you tackling OutDev, which I agree is a terrible hairball. Chris Sherlock wrote: > After this we need to start to tackle the issue of having to push > state around. IMO, we seem to have done this because that’s the way > a meta file does things. I do t believe t

Re: Problems with OutputDevice

2020-12-31 Thread Chris Sherlock
So I have a plan of attack that will alleviate some of these problems. It’s really a two pronged attack, which is actually just a gradual migration of code that can be done gradually. The two tasks are: Task: migrate fallback code out of OutputDevice and into SalGraphics. I have already starte

Problems with OutputDevice

2020-12-30 Thread Chris Sherlock
Hi all, Firstly, let me preface this by saying that most of you are far more experienced than I am with LibreOffice and C++. But in reality, you all know that LO is a bit of a hairball. When I started working on LibreOffice (and making many mistakes) it literally took me years to understand ho