Re: OutputDevice code reorganization

2014-04-16 Thread Chris Sherlock
Hi Kohei, I have a good deal of respect for your opinion, I've tried my best to keep the commit history :-) Thanks all for the responses! Chris On Wed, Apr 16, 2014 at 9:08 AM, Kohei Yoshida wrote: > On Tue, 2014-04-15 at 18:56 -0400, Kohei Yoshida wrote: > > On Wed, 2014-04-16 at 00:22 +0200

Re: OutputDevice code reorganization

2014-04-15 Thread Kohei Yoshida
On Tue, 2014-04-15 at 18:56 -0400, Kohei Yoshida wrote: > On Wed, 2014-04-16 at 00:22 +0200, Thorsten Behrens wrote: > > Kohei Yoshida wrote: > > > My only request is that the move be done in such a way that git knows > > > the files have been moved (in a single commit), rather than the old > > > f

Re: OutputDevice code reorganization

2014-04-15 Thread Kohei Yoshida
On Wed, 2014-04-16 at 00:22 +0200, Thorsten Behrens wrote: > Kohei Yoshida wrote: > > My only request is that the move be done in such a way that git knows > > the files have been moved (in a single commit), rather than the old > > files removed and new one added. > > > That is, for all intents an

Re: OutputDevice code reorganization

2014-04-15 Thread Thorsten Behrens
Kohei Yoshida wrote: > My only request is that the move be done in such a way that git knows > the files have been moved (in a single commit), rather than the old > files removed and new one added. > That is, for all intents and purposes, not going to work here, when methods are mixed and matched

Re: OutputDevice code reorganization

2014-04-15 Thread Kohei Yoshida
On Tue, 2014-04-15 at 10:00 -0500, Norbert Thiebaud wrote: > On Tue, Apr 15, 2014 at 6:25 AM, Chris Sherlock > wrote: > > I have moved outdev.cxx to outdev6.cxx to the directly vcl/source/outdev, > > and into the following files: > > > [...] > > > > I think this largely helps split up the file in

Re: OutputDevice code reorganization

2014-04-15 Thread Norbert Thiebaud
On Tue, Apr 15, 2014 at 6:25 AM, Chris Sherlock wrote: > I have moved outdev.cxx to outdev6.cxx to the directly vcl/source/outdev, > and into the following files: > [...] > > I think this largely helps split up the file in a more sensible layout. I'm sure ther is plenty of room to bikesheed this

OutputDevice code reorganization

2014-04-15 Thread Chris Sherlock
Hi all, In my ongoing efforts to refactor, document, understand and generally cleanup OutputDevice, I'm finding it increasingly hard to keep track of the way the files are laid out. Currently the files have very little order. The functions are split out into 6 seperate outdevx.cxx files (where x