Re: New tests: GTK3 platform accessibility

2024-08-01 Thread Michael Weghorn
On 2023-09-23 09:44, Michael Weghorn wrote: We noticed that at-spi2-core itself is using a similar approach to run its CI tests, which also fails when run in a Fedora 38 GNOME session. Colomban found this existing issue about running tests using dbus-broker on which I've commented now, hoping

Re: New tests: GTK3 platform accessibility

2023-09-23 Thread Michael Weghorn
On 2023-09-13 23:56, Michael Weghorn wrote: Or, if you're also attending LibreOffice conference next week in person, we could also take a look at it together then for example. Colomban and I analyzed this a bit further yesterday, without coming up with an actual solution yet. We noticed tha

Re: New tests: GTK3 platform accessibility

2023-09-17 Thread Michael Weghorn
On 2023-09-14 11:05, Colomban Wendling wrote: I'm on vacation this week, but could give this another try in my Fedora VM sometime afterwards. Or, if you're also attending LibreOffice conference next week in person, we could also take a look at it together then for example. I'll be there, we c

Re: New tests: GTK3 platform accessibility

2023-09-14 Thread Colomban Wendling
Le 13/09/2023 à 22:56, Michael Weghorn a écrit : On 2023-09-12 10:49, Colomban Wendling wrote: All that is a bit confusing to me, but let me try ton understand: - On a system using dbus-broker, when logged in under GNOME, test fails? - On *the same system*, but logging-in through SSH works!??

Re: New tests: GTK3 platform accessibility

2023-09-13 Thread Michael Weghorn
On 2023-09-12 10:49, Colomban Wendling wrote: All that is a bit confusing to me, but let me try ton understand: - On a system using dbus-broker, when logged in under GNOME, test fails? - On *the same system*, but logging-in through SSH works!?? Yes, that's what I've observed in a Fedora 38 VM.

Re: New tests: GTK3 platform accessibility

2023-09-12 Thread Stephan Bergmann
On 9/12/23 09:49, Colomban Wendling wrote: However, IIUC you suggest it might be a dbus/dbus-borken conflict somehow?  What if we try `dbus-broker-launch` (assuming it's compatible) instead of `dbus-launch` if the former is available?  Would that help? Doesn't appear to be compatible at all.

Re: New tests: GTK3 platform accessibility

2023-09-12 Thread Colomban Wendling
Le 29/08/2023 à 14:36, Michael Weghorn a écrit : […] This shows that there is an attempt to start a dbus session using dbus-broker-launch. This seems surprising at first, since dbus-run-session (and dbus-launch) use dbus-daemon in $PATH by default. But then, there's an at-spi-bus-launcher in

Re: New tests: GTK3 platform accessibility

2023-08-29 Thread Michael Weghorn
On 2023-08-28 19:54, Stephan Bergmann wrote: Otherwise: Does the test work when run in an X11 session instead? no; guess I need to install some piece of software that is missing from my machine I can reproduce in a GNOME session in a Fedora 38 VM. It seems to be related to GNOME and dbus-br

Re: New tests: GTK3 platform accessibility

2023-08-28 Thread Stephan Bergmann
On 8/25/23 09:06, Michael Weghorn wrote: In my test, it failed differently on Wayland, and forcing the X11 Gdk backend makes that work: https://gerrit.libreoffice.org/c/core/+/156086 Does that fix your case as well? no Otherwise: Does the test work when run in an X11 session instead? no;

Re: New tests: GTK3 platform accessibility

2023-08-25 Thread Michael Weghorn
On 2023-08-24 13:38, Stephan Bergmann wrote: When I --enable-atspi-tests (which passes configure) on my local Fedora 38 Linux machine, CppunitTest_vcl_gtk3_a11y fails the     assert(m_pAtspiApp); in Atspi2TestBase::setUp (vcl/qa/cppunit/a11y/atspi2/atspi2testbase.hxx), apparently becaus

Re: New tests: GTK3 platform accessibility

2023-08-24 Thread Stephan Bergmann
On 8/1/23 19:30, Colomban Wendling wrote: These tests are enabled by default if all dependencies are available. That is a working Xvfb [4], dbus-launch, and the AT-SPI2 library [5] which is used to communicate with the platform accessibility daemon.  It is also possible to either enable or disa

Re: New tests: GTK3 platform accessibility

2023-08-03 Thread Michael Weghorn
On 2023-08-01 19:30, Colomban Wendling wrote: Platform accessibility (a11y) conformance tests for the GTK3 VCL [1] have been merged a couple days ago.  This is a set of tests validating that the a11y exposed to the platform on Linux using the GTK3 VCL is coherent with the internal representatio

Re: New tests: GTK3 platform accessibility

2023-08-03 Thread Michael Weghorn
On 2023-08-03 16:58, Colomban Wendling wrote: OK… that's already quite a lot.  As CI passes on that changes (well, the relevant ones passed, the pending ones are irrelevant for this change), what about merging it and seeing if that number goes down? Sounds like a good way forward to me. I've m

Re: New tests: GTK3 platform accessibility

2023-08-03 Thread Colomban Wendling
Le 03/08/2023 à 16:51, Stephan Bergmann a écrit : On 8/3/23 16:37, Colomban Wendling wrote: Do you have an error rate value?  So I know how many successful CI runs I need to suggest it did indeed improve something :) Sorry, I at least cannot provide any useful numbers here.  I've noticed it b

Re: New tests: GTK3 platform accessibility

2023-08-03 Thread Stephan Bergmann
On 8/3/23 16:37, Colomban Wendling wrote: Do you have an error rate value?  So I know how many successful CI runs I need to suggest it did indeed improve something :) Sorry, I at least cannot provide any useful numbers here. I've noticed it both occasionally with the Jenkins builds of Gerrit

Re: New tests: GTK3 platform accessibility

2023-08-03 Thread Colomban Wendling
Le 03/08/2023 à 10:01, Stephan Bergmann a écrit : On 8/1/23 19:30, Colomban Wendling wrote: Linux CIs are running these tests, but anybody willing is encouraged to enable those locally and report any issue (don't hesitate to CC me). That CppunitTest_vcl_gtk3_a11y appears to be a frequent cause

Re: New tests: GTK3 platform accessibility

2023-08-03 Thread Stephan Bergmann
On 8/1/23 19:30, Colomban Wendling wrote: Linux CIs are running these tests, but anybody willing is encouraged to enable those locally and report any issue (don't hesitate to CC me). That CppunitTest_vcl_gtk3_a11y appears to be a frequent cause of failure now on Jenkins, with the typically fai

Re: New tests: GTK3 platform accessibility

2023-08-02 Thread Samuel Thibault
Colomban Wendling, le mar. 01 août 2023 19:30:05 +0200, a ecrit: > Platform accessibility (a11y) conformance tests for the GTK3 VCL [1] have > been merged a couple days ago. This is a set of tests validating that the > a11y exposed to the platform on Linux using the GTK3 VCL is coherent with > the

Re: New tests: GTK3 platform accessibility

2023-08-02 Thread Caolán McNamara
On Tue, 2023-08-01 at 19:30 +0200, Colomban Wendling wrote: > Hello everyone, > > Platform accessibility (a11y) conformance tests for the GTK3 VCL [1] > have been merged a couple days ago.  This is a set of tests > validating that the a11y exposed to the platform on Linux using the > GTK3 VCL is

New tests: GTK3 platform accessibility

2023-08-01 Thread Colomban Wendling
Hello everyone, Platform accessibility (a11y) conformance tests for the GTK3 VCL [1] have been merged a couple days ago. This is a set of tests validating that the a11y exposed to the platform on Linux using the GTK3 VCL is coherent with the internal representation in LO. This can catch (and