Re: Need help for unit test with rotated shape in Calc

2019-12-18 Thread Miklos Vajna
Hi Regina, On Tue, Dec 17, 2019 at 04:22:07PM +0100, Regina Henschel wrote: > It implements a method of class SdrObjCustomShape. That would speak for > "unit". But anyway, it is already in master > https://cgit.freedesktop.org/libreoffice/core/commit/?id=f44140bebb9c493d97ba5aef26c9692c53a6b93f

Re: Need help for unit test with rotated shape in Calc

2019-12-17 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 17-Dec-19 um 10:56: Hi Regina, On Sun, Dec 08, 2019 at 12:50:42AM +0100, Regina Henschel wrote: Question: Can I leave the test in "ScAnchorTest" in "extras", or should I create a new test class in "unit", where I copy the hierarchy of "ScAnchorTest", or som

Re: Need help for unit test with rotated shape in Calc

2019-12-17 Thread Miklos Vajna
Hi Regina, On Sun, Dec 08, 2019 at 12:50:42AM +0100, Regina Henschel wrote: > Question: Can I leave the test in "ScAnchorTest" in "extras", or should I > create a new test class in "unit", where I copy the hierarchy of > "ScAnchorTest", or something else? I think you can leave it there. My und

Re: Need help for unit test with rotated shape in Calc

2019-12-07 Thread Regina Henschel
Hi Miklos, I have made some progress :) I have put my test to sc/qa/extras/anchor.cxx. Everything works as expected there. My first attempt was in sc/qa/unit/bugfix-test.cxx. The difference seems to be, that class ScAnchorTest has a different class hierarchy including class MacrosTest, which

Re: Need help for unit test with rotated shape in Calc

2019-12-03 Thread Regina Henschel
Hi Miklos, Miklos Vajna schrieb am 03-Dec-19 um 11:22: Hi Regina, On Tue, Dec 03, 2019 at 01:38:59AM +0100, Regina Henschel wrote: Any idea, how I can apply FitToCellSize() to a shape in a unit test? Here is an sc/ test dispatching an UNO command: sc/qa/unit/screenshots/screenshots.cxx:30

Re: Need help for unit test with rotated shape in Calc

2019-12-03 Thread Miklos Vajna
Hi Regina, On Tue, Dec 03, 2019 at 01:38:59AM +0100, Regina Henschel wrote: > Any idea, how I can apply FitToCellSize() to a shape in a unit test? Here is an sc/ test dispatching an UNO command: sc/qa/unit/screenshots/screenshots.cxx:302 though this is commented out, but gives you an idea how

Need help for unit test with rotated shape in Calc

2019-12-02 Thread Regina Henschel
Hi all, my proposed fix for tdf#119191 in https://gerrit.libreoffice.org/#/c/84216/ will also fix, that the command .uno:FitCellSize does not work on cell anchored custom shapes, in case they are transformed. So I'm trying to write a unit test for it. The command is new [1] and has no unit te