Re: Moving Code From /core/sw... to /core/vcl

2013-02-06 Thread Joel Madero
On Wed, Feb 6, 2013 at 3:37 PM, Caolán McNamara wrote: > On Mon, 2013-02-04 at 11:18 +0100, Jan Holesovsky wrote: > > The code responsible for all this seems unnecessarily complicated to me, > > so I am sorry if my quick read is actually misleading - but in general, > > you don't want to move par

Re: Moving Code From /core/sw... to /core/vcl

2013-02-06 Thread Caolán McNamara
On Mon, 2013-02-04 at 11:18 +0100, Jan Holesovsky wrote: > The code responsible for all this seems unnecessarily complicated to me, > so I am sorry if my quick read is actually misleading - but in general, > you don't want to move parts of sw/ to vcl, more so if it meant > including headers from sw

Re: Moving Code From /core/sw... to /core/vcl

2013-02-04 Thread Jan Holesovsky
Hi Joel, Joel Madero píše v Út 29. 01. 2013 v 09:19 -0800: > This is the most challenging hack I've done and I'm looking for some > pointers. So - I tried to have a look, see my comments below, but Caolan will be able to give you a better advice, I'm sure :-) > So the option gets saved on pus

Moving Code From /core/sw... to /core/vcl

2013-01-29 Thread Joel Madero
Hi All, This is the most challenging hack I've done and I'm looking for some pointers. I am trying to make it so that pushing "Ok" on print dialog saves the component options. This is currently done in Writer (although imperfectly) within sw -- http://opengrok.libreoffice.org/xref/core/sw/source