gerrit changes depending one on another (was: Maarten Bosmans license statement)

2016-09-01 Thread Eike Rathke
Hi Maarten, On Wednesday, 2016-08-31 10:49:11 +0200, Maarten Bosmans wrote: > What is the correct way to submit a patch series to gerrit? I'd like > to avoid squashing all patches into one commit, but there also has to > be a way for reviewers to see that all patches in a series are > related. I

Re: gerrit changes depending one on another (was: Maarten Bosmans license statement)

2016-09-01 Thread Jan Iversen
> On 01 Sep 2016, at 18:01, Eike Rathke wrote: > > Hi Maarten, > > On Wednesday, 2016-08-31 10:49:11 +0200, Maarten Bosmans wrote: > >> What is the correct way to submit a patch series to gerrit? I'd like >> to avoid squashing all patches into one commit, but there also has to >> be a way for

Re: Maarten Bosmans license statement

2016-08-31 Thread Norbert Thiebaud
> > (unless it doesn't, and that means someone else has committed changes to the > same chunk of code in the meantime and your patch no longer applies, but let's > deal with that only when such situation arises) > >> What is the correct way to submit a patch series to gerrit? I'd like >> to avoid s

Re: Maarten Bosmans license statement

2016-08-31 Thread Katarina Behrens
Moin, > Both commits have difference Change-Id tags, but I submitted them > using a single `logerrit submit master` command. Now gerrit says for > the second patch: 'Cannot Merge'. I could not find what this means, > but I suppose that the second patch without the first does not apply > cleanly o

Re: Maarten Bosmans license statement

2016-08-31 Thread Maarten Bosmans
2016-08-30 16:41 GMT+02:00 Eike Rathke : > Great, we'll welcome your patches for review on gerrit :-) I have a question regarding the patch submission on gerrit. In searching for a faster way to implement SheetDataBuffer::addColXfStyle (for tdf#100709), I noticed that the current implementation ha

Re: Maarten Bosmans license statement

2016-08-30 Thread Eike Rathke
Hi Maarten, On Tuesday, 2016-08-30 12:59:10 +0200, Maarten Bosmans wrote: > I'm working on some performance issues loading Excel documents in Calc. > From looking into bugs 100709 and 53698 it seems to me that there's > ample opportunity to speed things up significantly (at least 2x) with > relat

Maarten Bosmans license statement

2016-08-30 Thread Maarten Bosmans
Hi developers, I'm working on some performance issues loading Excel documents in Calc. From looking into bugs 100709 and 53698 it seems to me that there's ample opportunity to speed things up significantly (at least 2x) with relatively minor changes. All of my past & future contributions to Libre