Re: LO 24.2 C++20 baseline

On Tue, 2023-09-26 at 10:44 +0200, Miklos Vajna wrote: > Hi, > > On Mon, Sep 25, 2023 at 01:48:01PM +0300, Stephan Bergmann > wrote: > > Was that maybe an intermittent Clang bug? It apparently doesn't hit the > > Jenkins Clang builds, and I don't see it with trunk Clang 18 either, but > > have

Re: LO 24.2 C++20 baseline

On 05.10.23 16:49, Stephan Bergmann wrote: As we just found out on IRC when Heiko ran into the above failures when compiling cli_ure/source/climaker/climaker_app.cxx, this apparently also affects old versions of VS 2022, not just VS 2019: No issue building master with VS Build Tools 17.7.4 which

Re: LO 24.2 C++20 baseline

On 10/4/23 13:56, Stephan Bergmann wrote: As "Drop some newly obsolete __cplusplus version checks" revealed, "at least for VS 2019 16.11.30 (but not for at least VS 2022 17.7.4), in /clr mode (e.g., when compiling

Re: LO 24.2 C++20 baseline

On 10/5/23 11:05, Michael Stahl wrote: On 04/10/2023 13:56, Stephan Bergmann wrote: (1)  Pretend that there is no issue.  Keep fingers crossed that "managed C++" source files compiled with /clr do not include any files that require a proper /std:c++20.  Or add more kludges similar to the above

Re: LO 24.2 C++20 baseline

On 04/10/2023 13:56, Stephan Bergmann wrote: etc.  To work around that, keep the 'O[U]String literals (unusable for now, C++20 only)' functionality disabled when compiling /clr sources (i.e., where _MANAGED is def

Re: LO 24.2 C++20 baseline

>/But reading />/https://learn.microsoft.com/en-us/visualstudio/releases/2022/system-requirements#visual-studio-2022-system-requirements, />/does it mean only devs need Windows 10 minimum or also LO users? />//No, that would only be a requirement for devs. So no pb at all considering Visual Studi

Re: LO 24.2 C++20 baseline

On Wed, 4 Oct 2023 at 17:12, Julien Nabet wrote: > But reading > https://learn.microsoft.com/en-us/visualstudio/releases/2022/system-requirements#visual-studio-2022-system-requirements, > does it mean only devs need Windows 10 minimum or also LO users? > No, that would only be a requirement for d

Re: LO 24.2 C++20 baseline

(3) Bump the MSVC baseline requirement from VS 2019 to VS 2022. +1 But reading https://learn.microsoft.com/en-us/visualstudio/releases/2022/system-requirements#visual-studio-2022-system-requirements, does it mean only devs need Windows 10 minimum or also LO users?

Re: LO 24.2 C++20 baseline

On 9/22/23 09:20, Stephan Bergmann wrote: I just submitted "Bump baseline to C++20" to master. I will let it sit like that for a few more days, to see if anything breaks (Coverity? Linux distros' needs? etc.) A

Re: LO 24.2 C++20 baseline

On 25/09/2023 20:56, Stephan Bergmann wrote: On 9/25/23 16:47, Caolán McNamara wrote: I'm guessing that https://gerrit.libreoffice.org/c/core/+/157250 would workaround this by just extending: commit 5831d5f03a5ea5b89984574ffe436f38500726da Date:   Tue Aug 1 15:37:45 2023 +0200 Don't enabl

Re: LO 24.2 C++20 baseline

Hi, On Mon, Sep 25, 2023 at 01:48:01PM +0300, Stephan Bergmann wrote: > Was that maybe an intermittent Clang bug? It apparently doesn't hit the > Jenkins Clang builds, and I don't see it with trunk Clang 18 either, but > have dim memories that there was some issue with too-eager evaluation > ca

Re: LO 24.2 C++20 baseline

On 9/25/23 16:47, Caolán McNamara wrote: I'm guessing that https://gerrit.libreoffice.org/c/core/+/157250 would workaround this by just extending: commit 5831d5f03a5ea5b89984574ffe436f38500726da Date: Tue Aug 1 15:37:45 2023 +0200 Don't enable the requires clause for some Xcode Clang wh

Re: LO 24.2 C++20 baseline

On Mon, 2023-09-25 at 08:30 +0200, Miklos Vajna wrote: > /home/vmiklos/git/libreoffice/core- > clang/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/XCl > oneable.hpp:8: > /home/vmiklos/git/libreoffice/core- > clang/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInt > erfac

Re: LO 24.2 C++20 baseline

On Mon, 2023-09-25 at 13:48 +0300, Stephan Bergmann wrote: > Was that maybe an intermittent Clang bug?  It apparently doesn't hit > the Jenkins Clang builds, and I don't see it with trunk Clang 18 > either I'm seeing it in oss-fuzz too FWIW, like https://oss-fuzz-build-logs.storage.googleapis.com/

Re: LO 24.2 C++20 baseline

On 9/25/23 08:30, Miklos Vajna wrote: gcc-12 looks fine here, but I hit an interesting problem with clang-15 (which worked fine before pulling): $ make animations make -j 16 -f /home/vmiklos/git/libreoffice/core-clang/compilerplugins/Makefile-clang.mk compilerplugins make[1]: Entering director

Re: LO 24.2 C++20 baseline

Hi Stephan, On Fri, Sep 22, 2023 at 10:20:31AM +0300, Stephan Bergmann wrote: > I just submitted > > "Bump baseline to C++20" to master. gcc-12 looks fine here, but I hit an interesting problem with clang-15 (wh

Re: LO 24.2 C++20 baseline

On Sun, 24 Sept 2023 at 00:33, David Gerard wrote: > On Sun, 24 Sept 2023 at 00:20, David Gerard wrote: > > For gcc 12, as i understand it I'd have to try to bodge in the debs > > from 22.10 (the current experimental version) or compile it from > > source. > sorry, I mean debs from 22.10 or lat

Re: LO 24.2 C++20 baseline

On Sun, 24 Sept 2023 at 00:20, David Gerard wrote: > For gcc 12, as i understand it I'd have to try to bodge in the debs > from 22.10 (the current experimental version) or compile it from > source. sorry, I mean debs from 22.10 or later - 22.10 and 23.04 supply gcc12, 23.10 supplies gcc13, so I'

Re: LO 24.2 C++20 baseline

> I just submitted > > "Bump baseline to C++20" to master. I will let it sit like that for a > few more days, to see if anything breaks (Coverity? Linux distros' > needs? etc.), before cleaning up now-unnecessary `

Re: LO 24.2 C++20 baseline

Hi Christian, Am 22.09.23 um 22:15 schrieb Christian Lohmaier: Hi Andreas, On Fri, Sep 22, 2023 at 11:09 PM Andreas Mantke wrote: You can also look in config.log for more details as to why it fails I tried with: export CC=/usr/bin/gcc-12 That's not enough, when doing it that way you'd also

Re: LO 24.2 C++20 baseline

Hi Andreas, On Fri, Sep 22, 2023 at 11:09 PM Andreas Mantke wrote: > You can also look in config.log for more details as to why it fails > > I tried with: > export CC=/usr/bin/gcc-12 That's not enough, when doing it that way you'd also have to export CXX (one for gcc compiler, the other env for

Re: LO 24.2 C++20 baseline

Hi Christian, Am 22.09.23 um 21:25 schrieb Christian Lohmaier: Hi Andreas, On Fri, Sep 22, 2023 at 9:31 PM Andreas Mantke wrote: You can upgrade to Leap 15.5 and compiling should work again: https://build.opensuse.org/package/show/openSUSE:Leap:15.5:Update/gcc12 unfortunately the upgrade did

Re: LO 24.2 C++20 baseline

Hi Andreas, On Fri, Sep 22, 2023 at 9:31 PM Andreas Mantke wrote: > > > You can upgrade to Leap 15.5 and compiling should work again: > https://build.opensuse.org/package/show/openSUSE:Leap:15.5:Update/gcc12 > > unfortunately the upgrade didn't fix the issue. I got this lines at the end > of the

Re: LO 24.2 C++20 baseline

Hi Ilmari, Am 22.09.23 um 18:05 schrieb Ilmari Lauhakangas: On 22.9.2023 18.36, Andreas Mantke wrote: Am 22.09.23 um 09:20 schrieb Stephan Bergmann: I just submitted "Bump baseline to C++20" to master.  I will

Re: LO 24.2 C++20 baseline

On 22.9.2023 18.36, Andreas Mantke wrote: Am 22.09.23 um 09:20 schrieb Stephan Bergmann: I just submitted "Bump baseline to C++20" to master.  I will let it sit like that for a few more days, to see if anything b

Re: LO 24.2 C++20 baseline

Hi Stephan, I tried to compile from master on openSUSE 15.4 without success yet. It complains about the compiler (the current tool chain is gcc 7). Regards, Andreas Am 22.09.23 um 09:20 schrieb Stephan Bergmann: I just submitted

LO 24.2 C++20 baseline

I just submitted "Bump baseline to C++20" to master. I will let it sit like that for a few more days, to see if anything breaks (Coverity? Linux distros' needs? etc.), before cleaning up now-unnecessary `#if __cplu