Re: Implement expected failures for CppUnit

2015-10-07 Thread Jan-Marek Glogowski
Am 07.10.2015 um 16:17 schrieb Jan-Marek Glogowski: > Hi Markus > > Does this also handle the inverse case, if the CPPUNIT_TEST_FAIL > actually passes, i.e. throws no exception? So I tested this myself. Guess I can abandon the patchset. Jan-Marek ___ L

Re: Implement expected failures for CppUnit

2015-10-07 Thread Jan-Marek Glogowski
Hi Markus Am 07.10.2015 um 14:21 schrieb Markus Mohrhard: > On Wed, Oct 7, 2015 at 2:11 PM, Jan-Marek Glogowski > wrote: > > Please keep in mind that this is possible with the current cppunit already. > The only difference (I'm not sure if that is really a useful feature) is > that your patch se

Re: Implement expected failures for CppUnit

2015-10-07 Thread Stephan Bergmann
On 10/07/2015 02:11 PM, Jan-Marek Glogowski wrote: Am 07.10.2015 um 12:47 schrieb Stephan Bergmann: On 10/07/2015 11:37 AM, Jan-Marek Glogowski wrote: I've implemented CPPUNIT_TEST_XFAIL to add test cases to a suite, which are expected to fail. Do you have some explanation what this is good f

Re: Implement expected failures for CppUnit

2015-10-07 Thread Markus Mohrhard
Hey, On Wed, Oct 7, 2015 at 2:11 PM, Jan-Marek Glogowski wrote: > Am 07.10.2015 um 12:47 schrieb Stephan Bergmann: > > On 10/07/2015 11:37 AM, Jan-Marek Glogowski wrote: > >> I've implemented CPPUNIT_TEST_XFAIL to add test cases to a suite, which > >> are expected to fail. > > > > Do you have so

Re: Implement expected failures for CppUnit

2015-10-07 Thread Jan-Marek Glogowski
Am 07.10.2015 um 12:47 schrieb Stephan Bergmann: > On 10/07/2015 11:37 AM, Jan-Marek Glogowski wrote: >> I've implemented CPPUNIT_TEST_XFAIL to add test cases to a suite, which >> are expected to fail. > > Do you have some explanation what this is good for? (My assumption is > that one would just

Re: Implement expected failures for CppUnit

2015-10-07 Thread Stephan Bergmann
On 10/07/2015 11:37 AM, Jan-Marek Glogowski wrote: I've implemented CPPUNIT_TEST_XFAIL to add test cases to a suite, which are expected to fail. Do you have some explanation what this is good for? (My assumption is that one would just write the test code in a way that it is supposed to succe

Implement expected failures for CppUnit

2015-10-07 Thread Jan-Marek Glogowski
Hi. I've implemented CPPUNIT_TEST_XFAIL to add test cases to a suite, which are expected to fail. See https://gerrit.libreoffice.org/#/c/19213/ https://gerrit.libreoffice.org/#/c/19214/ https://gerrit.libreoffice.org/#/c/19215/ The current approach unfortunately breaks the ABI and API. The API b