Hi Eike,
>To activate a test, in sc/qa/unit/subsequent_filters-test.cxx
>ScFiltersTest::testFunctionsExcel2010() in struct aTests simply change
>the corresponding row's bEvaluate member from false to true.
Thank you! :)
I have already included sc/qa/unit/subsequent_filters-test.cxx in my
checklis
Hi Winfried,
On Thursday, 2013-11-21 11:38:36 +0100, Winfried Donkers wrote:
> Do you intend to push this document with the tests disabled once I submit
> a patch with the tests for all functions currently present, based on the
> new document?
Done in
http://cgit.freedesktop.org/libreoffice/cor
Hi Winfried,
On Thursday, 2013-11-21 13:40:25 +0100, Winfried Donkers wrote:
> Fixed with https://gerrit.libreoffice.org/#/c/6751/
> I misread the background information and didn't have an original
> xlsx-document
> containing the function at the time I submitted the first patch.
Thanks a lot!
Hi Eike,
>Which reveals that our CONFIDENCE.T calculation seems to be wrong, there
>it results in 0.0837211385 whereas Excels calculates it as 1.5223611251
>Could you please investigate?
Fixed with https://gerrit.libreoffice.org/#/c/6751/
I misread the background information and didn't have an o
Hi Eike,
>>Attached to https://bugs.freedesktop.org/show_bug.cgi?id=70798 as
>>https://bugs.freedesktop.org/attachment.cgi?id=89539
>>Note that T.DIST.2T and T.INV.2T weren't correct, see bug comment.
>I will work on the unit test to include all functions that are currently
>present.
I added on
Hi Eike,
>Attached to https://bugs.freedesktop.org/show_bug.cgi?id=70798 as
>https://bugs.freedesktop.org/attachment.cgi?id=89539
>Note that T.DIST.2T and T.INV.2T weren't correct, see bug comment.
My typing error (which didn't show as I haven't added these functions yet).
I will work on the uni
Hi Winfried,
On Wednesday, 2013-11-20 18:25:49 +0100, Eike Rathke wrote:
> > https://bugs.freedesktop.org/attachment.cgi?id=89539
> Actually now https://bugs.freedesktop.org/attachment.cgi?id=89540
> with result and test columns.
Which reveals that our CONFIDENCE.T calculation seems to be wrong,
Hi Winfried,
On Wednesday, 2013-11-20 18:18:02 +0100, Eike Rathke wrote:
> Attached to https://bugs.freedesktop.org/show_bug.cgi?id=70798 as
> https://bugs.freedesktop.org/attachment.cgi?id=89539
Actually now https://bugs.freedesktop.org/attachment.cgi?id=89540
with result and test columns.
E
Hi Winfried,
On Monday, 2013-11-18 07:55:22 +0100, Winfried Donkers wrote:
> Attachment 89360 (https://bugs.freedesktop.org/attachment.cgi?id=89360) of
> bug 70798, see comment 9 for explanations.
> Note that the new xlsx-document may make the current tests fail because of
> relocation of funct
Hi Eike,
>> Should we add all new/renamed Excel2010 functions to that xlsx-document?
>> It isn't too much trouble for me, but I wouldn't like to give 'one of
>> you with Excel' work that is not necessary. :)
>I'd appreciate if you could add all the functions, send the document to me,
>I'd check
Hi Winfried,
On Friday, 2013-11-15 08:42:29 +0100, Winfried Donkers wrote:
> No problem, only AFAICS, the current test is more of a 'do _xlfn.-functions
> import correctly' kind.
That specific test case yes. We can add other tests to check correctness
of results (within bounds of rounding erro
Hi Eike,
>Best if at the same time you submit the unit test to gerrit you attach the
>.xlsx file edited to
>contain the additional tests to the BugZilla RFE with a short comment to mark
>it as interim.
>Only an import test case file written by Excel should be committed to the
>repository, wh
Hi Winfried,
On Tuesday, 2013-11-12 10:00:15 +0100, Winfried Donkers wrote:
> The tests Kohei added are of some functions I recently added (plus one
> that I'm still working on), so I will expand both the xlsx-file and
> the ScFiltersTest::testFunctionsExcel2010().
I did that for the recently ad
On Wed, 2013-11-13 at 07:59 +0100, Winfried Donkers wrote:
> as I seem to read that you offer help in creating the test file, that
> may not be a problem after all.:)
So... Our hope was to raise awareness of the importance of increasing
test cases (which includes creating test files) and attract m
Hi Markus,
>So Kohei just tested that the functions are imported without an error (which
>made sense as he was writing a test for a bug). What I was >suggesting for
>your case is that you take some of the corner cases that you know and write a
>test for them. This is what I started once for ODS
Hey Winfried,
2013/11/12 Winfried Donkers
> Hi Markus, Kohei, Eike,
>
> >Kohei added the tests with
> http://cgit.freedesktop.org/libreoffice/core/commit/sc/qa?id=c40cbf189750f623e065b6ed9596d90977a2f631
> >but at least IMO it makes more sense to add test cases similar to
> testFunctionODS just
Hi Markus, Kohei, Eike,
>Kohei added the tests with
>http://cgit.freedesktop.org/libreoffice/core/commit/sc/qa?id=c40cbf189750f623e065b6ed9596d90977a2f631
>
>but at least IMO it makes more sense to add test cases similar to
>testFunctionODS just for XLSX where you add corner cases for new funct
Hey Winfried,
2013/11/12 Winfried Donkers
> Hi Kohei,
>
> >> And a small request by me. Could we maybe add always directly an
> >> import/export test when we add a new function?
>
> >I did my share for my change. The ones that were missing from the test
> which went unnoticed by my change, I a
Hi Kohei,
>> And a small request by me. Could we maybe add always directly an
>> import/export test when we add a new function?
>I did my share for my change. The ones that were missing from the test which
>went unnoticed by my change, I added them.
>That said, I can't write all necessary test
And before anybody starts lecturing me on the importance of snipping
when replying on a thread (which I do understand very well), I do
apologize for not snipping the unrelated parts of the previous post. I
just realize that now... :-/
Kohei
___
LibreOf
On Tue, 2013-11-12 at 00:30 +0100, Markus Mohrhard wrote:
> Hey,
>
>
> 2013/11/11 Kohei Yoshida
> Hi there,
>
> Eike brought to my attention that my recent change to use the
> internal
> API to import formulas from xlsx broke the extra handling that
>
Hey,
2013/11/11 Kohei Yoshida
> Hi there,
>
> Eike brought to my attention that my recent change to use the internal
> API to import formulas from xlsx broke the extra handling that the UNO
> API was doing to translate some of the newer Excel functions from Excel
> 2010 and newer. These new fu
Hi there,
Eike brought to my attention that my recent change to use the internal
API to import formulas from xlsx broke the extra handling that the UNO
API was doing to translate some of the newer Excel functions from Excel
2010 and newer. These new functions are typically prefixed with _xlfn.
in
23 matches
Mail list logo
