Re: Gerrit review blocked on "Needs Code-Style"

2017-11-07 Thread Stephan Bergmann
On 11/07/2017 11:43 PM, Thorsten Behrens wrote: Stephan Bergmann wrote: Why is "Suppress loplugin:unnecessaryoverride..." blocked on "Needs Code-Style" (and which I at least cannot override via some +1 reply)? See mail a moment ago. Missed the fact t

Re: Gerrit review blocked on "Needs Code-Style"

2017-11-07 Thread Thorsten Behrens
Stephan Bergmann wrote: > Why is "Suppress > loplugin:unnecessaryoverride..." blocked on "Needs Code-Style" (and which I > at least cannot override via some +1 reply)? > See mail a moment ago. Missed the fact that the gerrit default submit rule is in effe

Gerrit review blocked on "Needs Code-Style"

2017-11-07 Thread Stephan Bergmann
Why is "Suppress loplugin:unnecessaryoverride..." blocked on "Needs Code-Style" (and which I at least cannot override via some +1 reply)? What's going on in our Gerrit? (Should that be an attempt at implementing the Gerrit-side clang-format enforce