Dear Christian,
On 02/06/17 12:17, Christian Lohmaier wrote:
On Mon, Feb 6, 2017 at 11:08 AM, Paul Menzel
wrote:
On 02/06/17 10:55, Christian Lohmaier wrote:
On Thu, Feb 2, 2017 at 1:05 PM, Paul Menzel wrote:
It is to prevent people from impersonating somebody else.
Think about someone tr
Hi Paul,
On Mon, Feb 6, 2017 at 11:08 AM, Paul Menzel
wrote:
> On 02/06/17 10:55, Christian Lohmaier wrote:
>> On Thu, Feb 2, 2017 at 1:05 PM, Paul Menzel wrote:
>>
>> It is to prevent people from impersonating somebody else.
>>
>> Think about someone trying your email to introduce a backdoor ...
Dear Jan,
On 02/06/17 12:00, jan iversen wrote:
Sorry, I still don’t see where the additional step is?
you submit the patch to gerrit, that does not put it into our core repo, but
only to the gerrit review repo. In order to merge the patch into our core
repo(typically master) a committer,
> Sorry, I still don’t see where the additional step is?
>
you submit the patch to gerrit, that does not put it into our core repo, but
only to the gerrit review repo. In order to merge the patch into our core
repo(typically master) a committer, needs to hit merge in gerrit, then will
mark the
Dear Christian,
On 02/06/17 10:55, Christian Lohmaier wrote:
On Thu, Feb 2, 2017 at 1:05 PM, Paul Menzel wrote:
I was asked to push a commit for review to the LO Gerrit instance [1].
The patch is from a colleague, who is denoted as the commit author. No
Gerrit complains, that I am not the a
Dear Jan,
On 02/06/17 10:56, jan iversen wrote:
Sorry, I didn’t understand *you have one step more merging to git*.
Patches in Gerrit are for review, when reviewed a committer merged them to the
git repo e.g, master, and from that time the are part of the LibreOffice code
base.
Sorry, I
>
> Sorry, I didn’t understand *you have one step more merging to git*.
Patches in Gerrit are for review, when reviewed a committer merged them to the
git repo e.g, master, and from that time the are part of the LibreOffice code
base.
rgds
jan i
__
Hi Paul, *,
On Thu, Feb 2, 2017 at 1:05 PM, Paul Menzel
wrote:
>
> I was asked to push a commit for review to the LO Gerrit instance [1].
>
> The patch is from a colleague, who is denoted as the commit author. No
> Gerrit complains, that I am not the author, and my colleagues email address
> is
Dear Jan,
On 02/06/17 10:43, jan iversen wrote:
I don’t see how that is required. In Gerrit, it would still be clear, who
pushed the patch (owner).
>
yes but you have one step more merging to git, and if that is done by a third
person information would be lost.
Sorry, I didn’t understan
> I don’t see how that is required. In Gerrit, it would still be clear, who
> pushed the patch (owner).
yes but you have one step more merging to git, and if that is done by a third
person information would be lost.
> Please tell me how. Do you want me send the patch to the mailing list?
yes or
Dear Jan,
On 02/06/17 10:32, Jan Iversen wrote:
The gerrit allows people with committer status, to push patches for other
people. In that case the email addr, from the person pushing becomes committer
email, and the email from from patch owner becomes the author.
To do this please remember
Hi
The gerrit allows people with committer status, to push patches for other
people. In that case the email addr, from the person pushing becomes committer
email, and the email from from patch owner becomes the author.
To do this please remember to use —author and —author-email in the commit
s
Dear LibreOffice folks,
I was asked to push a commit for review to the LO Gerrit instance [1].
The patch is from a colleague, who is denoted as the commit author. No
Gerrit complains, that I am not the author, and my colleagues email
address is not registered to *my* Gerrit account.
Could y
13 matches
Mail list logo
