Re: Faulty handle position in shapes imported from MS Office (continued)

Hi all, and here is a version without switch, but with a sequence of "if" statements: https://gerrit.libreoffice.org/70712 Still the same question, what way to go and where to put the parts? Kind regards Regina Regina Henschel schrieb am 13-Apr-19 um 01:33: Hi all, I have mentioned in the p

Faulty handle position in shapes imported from MS Office (continued)

Hi all, I have mentioned in the previous thread, that I'll make a proposal, so that discussing a solution is easier. For my first ideas, see now https://gerrit.libreoffice.org/70689. Please take a look at the proposal. Is the way suitable in principle? I am so indecisive, because both "enum"

Re: Faulty handle position in shapes imported from MS Office

Hi Mark, Mark Hung schrieb am 11-Apr-19 um 13:21: The equation should hold: (adj1-adj0) = (y1-y0) * 10 / height. I think this should cover lots of cases already. [..] I think the patterns of the formula is much less than the number of types. Maybe worthy of identify them? Yes, I'm curre

Re: Faulty handle position in shapes imported from MS Office

Regina Henschel 於 2019年4月11日 週四 下午6:55寫道： > Miklos Vajna schrieb am 11-Apr-19 um 09:59: > > Hi Regina, > > > > I might be wrong, but I would expect that the evaluation of the formulas > > don't depend on the shape type. If it does, it feels we don't understand > > the general rule, so we work the

Re: Faulty handle position in shapes imported from MS Office

Miklos Vajna schrieb am 11-Apr-19 um 09:59: Hi Regina, I might be wrong, but I would expect that the evaluation of the formulas don't depend on the shape type. If it does, it feels we don't understand the general rule, so we work the problem around with evaluating a formula in different ways f

Re: Faulty handle position in shapes imported from MS Office

Hi Regina, On Wed, Apr 10, 2019 at 02:41:17PM +0200, Regina Henschel wrote: > The needed calculation depends on the shape type, the handle and the > parameter ( X, Y, Radius, Angle) of the handle. Different handles of a shape > can need different calculations. On the other hand, different shapes

Re: Faulty handle position in shapes imported from MS Office

Hi Miklos, hi others, Miklos Vajna schrieb am 10-Apr-19 um 10:20: It feel like the correct place to fix this is where we interpret the formulas. If it can be done without taking the shape type into account, that sounds ideal. But I did not look into this personally. The needed calculation dep

Re: Faulty handle position in shapes imported from MS Office

Hi Regina, On Tue, Apr 09, 2019 at 08:55:26PM +0200, Regina Henschel wrote: > Does that mean, that you suggest to tweak the set of formulas, which are > generated for a shape in a way, that method SetHandleControllerPosition can > use the same calculation for all shapes? That sounds more complic

Re: Faulty handle position in shapes imported from MS Office

Hi Regina, Regina Henschel 於 2019年4月10日 週三 上午2:38寫道： > Hi Mark, > > Mark Hung schrieb am 09-Apr-19 um 11:27: > > Hi Regina, > > > > Regina Henschel > > 於 2019年4月9日 週二 上午7:06寫道： > > > > Hi all, > > > > I'm looking at > > https://bugs.documentfoundation

Re: Faulty handle position in shapes imported from MS Office

Hi Miklos, Miklos Vajna schrieb am 09-Apr-19 um 09:30: Hi Regina, On Tue, Apr 09, 2019 at 01:06:12AM +0200, Regina Henschel wrote: What to do? In principle you can get the needed operations from the presets as defined in the standard. But how to organize that, so that it can be done step by

Re: Faulty handle position in shapes imported from MS Office

Hi Mark, Mark Hung schrieb am 09-Apr-19 um 11:27: Hi Regina, Regina Henschel > 於 2019年4月9日 週二 上午7:06寫道： Hi all, I'm looking at https://bugs.documentfoundation.org/show_bug.cgi?id=115813 "Position shifted while moving the handle of OOXML Callout

Re: Faulty handle position in shapes imported from MS Office

Hi Regina, Regina Henschel 於 2019年4月9日 週二 上午7:06寫道： > Hi all, > > I'm looking at https://bugs.documentfoundation.org/show_bug.cgi?id=115813 > "Position shifted while moving the handle of OOXML Callout shape". > > Unfortunately not only the Callout shape is affected. > There are 106 shapes in MS

Re: Faulty handle position in shapes imported from MS Office

Hi Regina, On Tue, Apr 09, 2019 at 01:06:12AM +0200, Regina Henschel wrote: > What to do? In principle you can get the needed operations from the presets > as defined in the standard. But how to organize that, so that it can be done > step by step and perhaps can be done by several people? And,

Faulty handle position in shapes imported from MS Office

Hi all, I'm looking at https://bugs.documentfoundation.org/show_bug.cgi?id=115813 "Position shifted while moving the handle of OOXML Callout shape". Unfortunately not only the Callout shape is affected. There are 106 shapes in MS Office, which have handles. 38 are OK with the current implementa