Re: FastSaxSerializer::write ...

2016-01-21 Thread David Tardon
Hi, On Wed, Jan 20, 2016 at 11:54:41AM -0600, Norbert Thiebaud wrote: > On Wed, Jan 20, 2016 at 9:37 AM, David Tardon wrote: > > Hi, > > > > On Mon, Jan 18, 2016 at 12:53:07PM +1100, Chris Sherlock wrote: > >> I think a unit test might be helpful. They are actually quite easy to > >> write - in

Re: FastSaxSerializer::write ...

2016-01-21 Thread Stephan Bergmann
On 01/20/2016 09:25 PM, Michael Meeks wrote: Amusingly, while the sal/ tests -look- good ;-) many of them are simply not run because they fail to register the actual tests - which is not ideal (or did that get fixed?); At least cases where a test function is not added with CPPUNIT_TEST

Re: FastSaxSerializer::write ...

2016-01-20 Thread Michael Meeks
On Wed, 2016-01-20 at 11:54 -0600, Norbert Thiebaud wrote: > > Speaking about excessively granular tests: would anyone protest against > > an Easy Hack to merge the tests in sal module into bigger groups, e.g., > > Yeah but in general merging create trouble with parallelism > if you have only

Re: FastSaxSerializer::write ...

2016-01-20 Thread Norbert Thiebaud
On Wed, Jan 20, 2016 at 9:37 AM, David Tardon wrote: > Hi, > > On Mon, Jan 18, 2016 at 12:53:07PM +1100, Chris Sherlock wrote: >> I think a unit test might be helpful. They are actually quite easy to write >> - in fact, I wrote a very simple one the other day. >> >> Have a look on master at vcl/q

Re: FastSaxSerializer::write ...

2016-01-20 Thread Chris Sherlock
> On 21 Jan 2016, at 2:37 AM, David Tardon wrote: > > Hi, > > On Mon, Jan 18, 2016 at 12:53:07PM +1100, Chris Sherlock wrote: >> I think a unit test might be helpful. They are actually quite easy to write >> - in fact, I wrote a very simple one the other day. >> >> Have a look on master at v

Re: FastSaxSerializer::write ...

2016-01-20 Thread David Tardon
Hi, On Mon, Jan 18, 2016 at 12:53:07PM +1100, Chris Sherlock wrote: > I think a unit test might be helpful. They are actually quite easy to write - > in fact, I wrote a very simple one the other day. > > Have a look on master at vcl/qa/cppunit/font.cxx Note that you don't have to create a whol

Re: FastSaxSerializer::write ...

2016-01-18 Thread Michael Meeks
Hi Mark, On Sat, 2016-01-16 at 21:36 +0800, Mark Hung wrote: > I'd look into performance issue. Thanks =) should be an easy tweak there. > Is there any benchmark or unit test that I can use to check > performance enhancement ? Looking at a profile quickly; it seems that I get a

Re: FastSaxSerializer::write ...

2016-01-17 Thread Chris Sherlock
t; Hi Mark, > > Great to see: > > commit e99f22bbc499ab0566621ee0bb01e4a7747efe76 > Author: Mark Hung mailto:mark...@gmail.com>> > Date: Sun Jan 10 00:28:14 2016 +0800 > > Fix FastSaxSerializer::write() for non-BMP unicode characters. > > Clea

Re: FastSaxSerializer::write ...

2016-01-16 Thread Mark Hung
ee: > > commit e99f22bbc499ab0566621ee0bb01e4a7747efe76 > Author: Mark Hung > Date: Sun Jan 10 00:28:14 2016 +0800 > > Fix FastSaxSerializer::write() for non-BMP unicode characters. > > Clearly we don't want to mangle UTF-16 etc. characters - and the > code &g

FastSaxSerializer::write ...

2016-01-16 Thread Michael Meeks
Hi Mark, Great to see: commit e99f22bbc499ab0566621ee0bb01e4a7747efe76 Author: Mark Hung Date: Sun Jan 10 00:28:14 2016 +0800 Fix FastSaxSerializer::write() for non-BMP unicode characters. Clearly we don't want to mangle UTF-16 etc. characters - and the code looks