Re: Enabling gobject-introspection support in gtk3 builds

2015-09-14 Thread Miklos Vajna
Hi, On Mon, Sep 14, 2015 at 10:20:11AM +0200, David Tardon wrote: > IMHO tools that are not needed for standard build (make && make check) > should not be checked for by default. What about be the appropriate conditional (--enable-foo) that should trigger the check? --with-package-format is a c

Re: Enabling gobject-introspection support in gtk3 builds

2015-09-14 Thread David Tardon
Hi, On Mon, Sep 14, 2015 at 10:13:47AM +0200, Miklos Vajna wrote: > Hi, > > On Sun, Sep 13, 2015 at 05:09:57PM +0530, Pranav Kant > wrote: > > That is indeed correct. I have fixed that and updated the patch. > > Thanks, pushed now to master. > > Tin

Re: Enabling gobject-introspection support in gtk3 builds

2015-09-14 Thread Miklos Vajna
Hi, On Sun, Sep 13, 2015 at 05:09:57PM +0530, Pranav Kant wrote: > That is indeed correct. I have fixed that and updated the patch. Thanks, pushed now to master. Tinderbox owners: if autogen.sh now fails, please either disable gobject-introspection su

Re: Enabling gobject-introspection support in gtk3 builds

2015-09-13 Thread Pranav Kant
On Sun, Sep 13, 2015 at 4:36 PM, Rene Engelhard wrote: > > So I think one wants to change > > > > --library=libreofficekitgtk > --library-path="${INSTALLDIR}/program/libreofficekitgtk" \ > > > > into > > > > --library=libreofficekitgtk > --library-path="${DESTDIR}/${INST

Re: Enabling gobject-introspection support in gtk3 builds

2015-09-13 Thread Rene Engelhard
> So I think one wants to change > > --library=libreofficekitgtk > --library-path="${INSTALLDIR}/program/libreofficekitgtk" \ > > into > > --library=libreofficekitgtk > --library-path="${DESTDIR}/${INSTALLDIR}/program/libreofficekitgtk" \ Of course I meant --library

Re: Enabling gobject-introspection support in gtk3 builds

2015-09-12 Thread Rene Engelhard
On Fri, Sep 11, 2015 at 12:09:06PM +0200, Miklos Vajna wrote: > The commit to enable that for distributions is at > . configure is updated to > check for the newly required necessary tools. My understanding is that [...]> > Knowing that, am I OK to push t

Enabling gobject-introspection support in gtk3 builds

2015-09-11 Thread Miklos Vajna
Hi, Part of Pranav's GSoC project was to tweak the gtk widget in libreofficekit/ so that it follows the rules that allows access to it from other languages. For example, gnome-document's use-case is javascript. The commit to enable that for distributions is at