Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Lubos Lunak
On Wednesday 31 of October 2012, Markus Mohrhard wrote: > I still don't see how the three different switches are confusing: > > enable-symbol: only add debugging symbols but still with optimization > enable-debug: additionally no optimization to make it easier to debug and debug output > enable-

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Markus Mohrhard
2012/10/31 Norbert Thiebaud : > On Wed, Oct 31, 2012 at 10:35 AM, Lubos Lunak wrote: >> On Wednesday 31 of October 2012, Norbert Thiebaud wrote: >>> On Wed, Oct 31, 2012 at 8:34 AM, Lubos Lunak wrote: >>> > I'd prefer to not bring it back because of a special use case that's >>> > already easily

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Norbert Thiebaud
On Wed, Oct 31, 2012 at 10:52 AM, Norbert Thiebaud wrote: > On Wed, Oct 31, 2012 at 10:35 AM, Lubos Lunak wrote: >> On Wednesday 31 of October 2012, Norbert Thiebaud wrote: >>> On Wed, Oct 31, 2012 at 8:34 AM, Lubos Lunak wrote: >>> > I'd prefer to not bring it back because of a special use case

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Norbert Thiebaud
On Wed, Oct 31, 2012 at 10:35 AM, Lubos Lunak wrote: > On Wednesday 31 of October 2012, Norbert Thiebaud wrote: >> On Wed, Oct 31, 2012 at 8:34 AM, Lubos Lunak wrote: >> > I'd prefer to not bring it back because of a special use case that's >> > already easily doable as it is. >> >> Well tinderbo

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Lubos Lunak
On Wednesday 31 of October 2012, Norbert Thiebaud wrote: > On Wed, Oct 31, 2012 at 8:34 AM, Lubos Lunak wrote: > > I'd prefer to not bring it back because of a special use case that's > > already easily doable as it is. > > Well tinderbox works nicely and easily with an autogen.lastrun > associate

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Stephan Bergmann
On 10/31/2012 03:40 PM, Norbert Thiebaud wrote: On Wed, Oct 31, 2012 at 8:34 AM, Lubos Lunak wrote: I'd prefer to not bring it back because of a special use case that's already easily doable as it is. Well tinderbox works nicely and easily with an autogen.lastrun associated with a given profi

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Norbert Thiebaud
On Wed, Oct 31, 2012 at 8:34 AM, Lubos Lunak wrote: > I'd prefer to not bring it back because of a special use case that's already > easily doable as it is. Well tinderbox works nicely and easily with an autogen.lastrun associated with a given profile... messing with env variable is not as neat a

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Lubos Lunak
On Tuesday 30 of October 2012, Markus Mohrhard wrote: > 2012/10/30 Kohei Yoshida : > > On 10/30/2012 05:27 PM, Lubos Lunak wrote: > >> > >> make CFLAGS='-O -g' CXXFLAGS='-O -g' LDFLAGS='' > >> > >> If that doesn't work then I need to fix it. > > > > Well, the idea is to *just* add -g to the fla

Re: ENABLE_SYMBOLS=true does nothing

2012-10-31 Thread Stephan Bergmann
On 10/30/2012 11:11 PM, David Ostrovsky wrote: On 30.10.2012 22:03, Kohei Yoshida wrote: So, this script can add -g to the CXXFLAGS, but unfortunately the symbols get stripped during linking because of -Wl,-S option passed to the linker. grep -r LINKERSTRIPDEBUGFLAGS * LinkTarget.mk:gb_LinkTar

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Norbert Thiebaud
On Tue, Oct 30, 2012 at 5:11 PM, Michael Stahl wrote: > On 30/10/12 22:35, Markus Mohrhard wrote: >> 2012/10/30 Kohei Yoshida : >>> Well, the idea is to *just* add -g to the flags without modifying any other >>> flags, and *just* remove -Wl,-S from LDFLAGS without removing other flags. >>> Changin

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Kohei Yoshida
On Tue, Oct 30, 2012 at 6:11 PM, Michael Stahl wrote: > the --enable-symbols option and related ENABLE_SYMBOLS variable were > removed because nobody used or needed them (except for release builders, > who (it was argued) can just set CXXFLAGS instead). > > since there is now evidence of actual u

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Michael Stahl
On 30/10/12 22:35, Markus Mohrhard wrote: > 2012/10/30 Kohei Yoshida : >> Well, the idea is to *just* add -g to the flags without modifying any other >> flags, and *just* remove -Wl,-S from LDFLAGS without removing other flags. >> Changing other flags will change the generated binaries which may af

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread David Ostrovsky
On 30.10.2012 22:03, Kohei Yoshida wrote: ... inside a module should just enable debug symbols, and nothing but symbols. So, this script can add -g to the CXXFLAGS, but unfortunately the symbols get stripped during linking because of -Wl,-S option passed to the linker. grep -r LINKERSTRI

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Markus Mohrhard
2012/10/30 Kohei Yoshida : > On 10/30/2012 05:27 PM, Lubos Lunak wrote: >> >> On Tuesday 30 of October 2012, Kohei Yoshida wrote: >>> >>> So, this script can add -g to the CXXFLAGS, but unfortunately the >>> symbols get stripped during linking because of -Wl,-S option passed to >>> the linker. >>>

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Kohei Yoshida
On 10/30/2012 05:27 PM, Lubos Lunak wrote: On Tuesday 30 of October 2012, Kohei Yoshida wrote: So, this script can add -g to the CXXFLAGS, but unfortunately the symbols get stripped during linking because of -Wl,-S option passed to the linker. To work around this, I need to find a way to not ad

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Lubos Lunak
On Tuesday 30 of October 2012, Kohei Yoshida wrote: > So, this script can add -g to the CXXFLAGS, but unfortunately the > symbols get stripped during linking because of -Wl,-S option passed to > the linker. > > To work around this, I need to find a way to not add this -S option to > the linker flag

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Ruslan Kabatsayev
Dirty workaround would be to make a wrapper around ld, which would filter the command line and call real ld. On Wed, Oct 31, 2012 at 1:03 AM, Kohei Yoshida wrote: > On 10/30/2012 04:07 PM, Kohei Yoshida wrote: >> >> On 10/30/2012 03:42 PM, Lubos Lunak wrote: >>> >>> On Tuesday 30 of October 2012,

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Kohei Yoshida
On 10/30/2012 04:07 PM, Kohei Yoshida wrote: On 10/30/2012 03:42 PM, Lubos Lunak wrote: On Tuesday 30 of October 2012, Kohei Yoshida wrote: Hi there, Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't seem to turn on symbols. Does this ring a bell to anyone? http://li

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Kohei Yoshida
On 10/30/2012 03:42 PM, Lubos Lunak wrote: On Tuesday 30 of October 2012, Kohei Yoshida wrote: Hi there, Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't seem to turn on symbols. Does this ring a bell to anyone? http://lists.freedesktop.org/archives/libreoffice/2012

Re: ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Lubos Lunak
On Tuesday 30 of October 2012, Kohei Yoshida wrote: > Hi there, > > Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't > seem to turn on symbols. > > Does this ring a bell to anyone? http://lists.freedesktop.org/archives/libreoffice/2012-October/040051.html -- Lubos Lunak

ENABLE_SYMBOLS=true does nothing

2012-10-30 Thread Kohei Yoshida
Hi there, Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't seem to turn on symbols. Does this ring a bell to anyone? Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop