On Saturday 05 of January 2013, Michael Meeks wrote:
> On Fri, 2013-01-04 at 15:12 +0100, Lubos Lunak wrote:
> Having said that - it is something we really want to do; can we drop
> the published easy hack bug in this regard (or just close it) to avoid
> the drip of patches there ?
I'm not
On Fri, 2013-01-04 at 15:12 +0100, Lubos Lunak wrote:
> The patch specifically is string rtl:: prefix removal.
Nice work ! :-)
> - wait until before 4-1 branch-off (or do not do such a big change at all) -
> this would mean there still would be these changes done in small bits by
> o
On Fri, Jan 4, 2013 at 8:12 AM, Lubos Lunak wrote:
> so this hopefully should be safe, but most of
> the changes have been done using sed, so there may be something that I've
> missed
Well that is the crux of it isn't it ?
Although the risk per change is small, with that many changes there
are i
Hi,
On 01/04/2013 03:12 PM, Lubos Lunak wrote:
Hello,
I have a patch that is 32M big and I rather wonder when to commit it.
The patch specifically is string rtl:: prefix removal. These changes
regularly show up in gerrit patches for review, but I think we have somewhat
better EasyHacks
.) so we'll got to
check master and 4.0 Tinderboxes and fix quickly if red (hopefully it's just
quick and easy fix)
However, again the last solution you proposed seems the best.
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Doing-massive-source-changes-tp
Hi,
I would recommend going with the last option,
when i looked on the reviews it is pretty mindless search and replace
so the only issue is to make sure the replace script wont bork stuff.
Cheers
Tom
2013/1/4 Lubos Lunak :
>
> Hello,
>
> I have a patch that is 32M big and I rather wonder whe
Hello,
I have a patch that is 32M big and I rather wonder when to commit it.
The patch specifically is string rtl:: prefix removal. These changes
regularly show up in gerrit patches for review, but I think we have somewhat
better EasyHacks for new developers than rather mindless search&repl
