On Mon, 2012-03-26 at 18:03 +0400, Ivan Timofeev wrote:
> Hi Julien,
>
> On 24.03.2012 03:26, julien2412 wrote:
> > Just for the update, is there anybody who could help about this ?
>
> I am not expert, too, but looking at vcl/source/gdi/sallayout.cxx:115
> and http://www.unicode.org/charts/PDF/
Hi Julien,
On 24.03.2012 03:26, julien2412 wrote:
Just for the update, is there anybody who could help about this ?
I am not expert, too, but looking at vcl/source/gdi/sallayout.cxx:115
and http://www.unicode.org/charts/PDF/UFF00.pdf I'd say that the
condition should be at least
(nChar >=
Just for the update, is there anybody who could help about this ?
Julien
--
View this message in context:
http://nabble.documentfoundation.org/Cppcheck-reports-Logical-conjunction-always-evaluates-to-false-in-text-gfx-cxx-tp3836511p3852917.html
Sent from the Dev mailing list archive at Nabble.co
On 03/19/2012 10:25 PM, julien2412 wrote:
remarks :
- I replaced this
nChar>= 0xff62&& nChar< 0xff64
by this for readability
nChar == 0xff62 || nChar == 0xff63
- I added in the outer "if", "nChar == 0xffe3" because if not, "nChar ==
0xffe3" in the inner "if" is useless.
Is this patch
Here is a patch :
http://nabble.documentfoundation.org/file/n3840411/text_gfx_patch.txt
text_gfx_patch.txt
remarks :
- I replaced this
nChar >= 0xff62 && nChar < 0xff64
by this for readability
nChar == 0xff62 || nChar == 0xff63
- I added in the outer "if", "nChar == 0xffe3" because if n
On 03/18/2012 02:39 PM, julien2412 wrote:
Cppcheck reports this :
[generic/print/text_gfx.cxx:105]: (warning) Logical conjunction always
Would be helpful if you gave the complete path,
vcl/generic/print/text_gfx.cxx.
evaluates to false: nChar< 65380&& nChar>= 65387
Here are the lines :
Hello,
Cppcheck reports this :
[generic/print/text_gfx.cxx:105]: (warning) Logical conjunction always
evaluates to false: nChar < 65380 && nChar >= 65387
Here are the lines :
103 if( ( nChar >= 0x3008 && nChar < 0x3019 && nChar != 0x3012 )
||
104 nChar == 0xff3b || nCha
