Re: Cppcheck report in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx

2012-10-21 Thread julien2412
Ivan Timofeev wrote > On 20.10.2012 22:23, julien2412 wrote: >> [gdi/salnativewidgets-gtk.cxx:3452] -> >> [gdi/salnativewidgets-gtk.cxx:3462]: >> (performance) Variable 'eState' is reassigned a value before the old one >> has >> been used. >> Is the line 3452 could just be removed or should this pa

Re: Cppcheck report in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx

2012-10-21 Thread Ivan Timofeev
On 20.10.2012 22:23, julien2412 wrote: > Hello, > > Just noticed this with cppcheck: > [gdi/salnativewidgets-gtk.cxx:3452] -> [gdi/salnativewidgets-gtk.cxx:3462]: > (performance) Variable 'eState' is reassigned a value before the old one has > been used. > Here are the lines: >3452 GtkStat

Cppcheck report in vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx

2012-10-20 Thread julien2412
Hello, Just noticed this with cppcheck: [gdi/salnativewidgets-gtk.cxx:3452] -> [gdi/salnativewidgets-gtk.cxx:3462]: (performance) Variable 'eState' is reassigned a value before the old one has been used. Here are the lines: 3452 GtkStateType eState = (nState & CTRL_STATE_ENABLED) ? GTK_STAT