Re: Bug 83260

2018-01-11 Thread Matthew J. Francis
On 12/01/2018 13:18, Yemelyanenko Fyodor wrote: Withthese modification LO is stable when autocreecting and Undo/Redo Patchis here https://gerrit.libreoffice.org/47686 Thanks for persisting to find a good solution for this. It's much appreciated Regards Matthew Francis

Re[2]: Bug 83260

2018-01-11 Thread Yemelyanenko Fyodor
. -- Исходное сообщение -- От: "Miklos Vajna" mailto:vmik...@collabora.co.uk>> Кому: "libreoffice@lists.freedesktop.org" mailto:libreoffice@lists.freedesktop.org>> Отправлено: 10.01.2018 19:26:27 Тема: Re: Bug 83260 Hi, On Tue, Jan 09, 2018 at 05:10:00AM +, Y

Re: Bug 83260

2018-01-10 Thread Wols Lists
On 10/01/18 09:26, Miklos Vajna wrote: > Yes, that's a known behavior, in the past I broke it and it created a > new redline every second, that was not funny. ;-) Can I just add, thinking with my user hat on, this can be somewhat of a shock to the user - principle of least surprise etc and "why wh

Re: Bug 83260

2018-01-10 Thread Miklos Vajna
Hi, On Tue, Jan 09, 2018 at 05:10:00AM +, Yemelyanenko Fyodor wrote: > I think that the best solution for bug in question is to remove call to > CompresRedlines from Undo/Redo. So Undo/Redo won't compress redlines and > change indexes. > I don't like to change CompresRedlines as it called

Re[2]: Bug 83260

2018-01-09 Thread Yemelyanenko Fyodor
От: "Miklos Vajna" mailto:vmik...@collabora.co.uk>> Кому: "libreoffice@lists.freedesktop.org" mailto:libreoffice@lists.freedesktop.org>> Отправлено: 08.01.2018 19:22:13 Тема: Re: Bug 83260 Hi, On Sat, Jan 06, 2018 at 01:20:05AM +, Yemelyanenko Fyodor mailto:fyodo...@hotmail.

Re: Bug 83260

2018-01-08 Thread Miklos Vajna
Hi, On Sat, Jan 06, 2018 at 01:20:05AM +, Yemelyanenko Fyodor wrote: > Now I’m investigating CompresRedlines further. I think it can be > changed so it merges only two neighbor redlines in the same node and > not merge cross-node. Or maybe it should be completely removed, as it > only merges

Re[2]: Bug 83260

2018-01-07 Thread Yemelyanenko Fyodor
.freedesktop.org<mailto:libreoffice@lists.freedesktop.org> Отправлено: 05.01.2018 18:35:12 Тема: Re: Bug 83260 Hi, On Thu, Jan 04, 2018 at 09:45:14AM +0800, "Matthew J. Francis" mailto:mjay.fran...@gmail.com>> wrote: I use tracked changes on a regular basis, and would much rather th

Re: Bug 83260

2018-01-05 Thread Miklos Vajna
Hi, On Thu, Jan 04, 2018 at 09:45:14AM +0800, "Matthew J. Francis" wrote: > I use tracked changes on a regular basis, and would much rather this be > treated as "maybe difficult but important to get right" than "too hard, so > don't bother" Perhaps a middle ground is to give up undo/redo only f

Re: Bug 83260

2018-01-03 Thread Matthew J. Francis
On 04/01/2018 09:45, Matthew J. Francis wrote: On 03/01/2018 17:42, Miklos Vajna wrote: [...] We raise a similar warning when deleting a header, you can probably reuse that code here. And sure, clearing the undo stack instead of crashing sounds like an improvement (especially if we ask the us

Re: Bug 83260

2018-01-03 Thread Matthew J. Francis
On 03/01/2018 17:42, Miklos Vajna wrote: Hi, On Fri, Dec 22, 2017 at 06:56:53AM +, Yemelyanenko Fyodor wrote: For now I see 2 possible solutions: 1. Rewrite redlining, so Show option will change how doc is viewed, but not how it is formed (list of nodes) 2. When toggling change tracking o

Re: Bug 83260

2018-01-03 Thread Miklos Vajna
Hi, On Fri, Dec 22, 2017 at 06:56:53AM +, Yemelyanenko Fyodor wrote: > For now I see 2 possible solutions: > 1. Rewrite redlining, so Show option will change how doc is viewed, but > not how it is formed (list of nodes) > 2. When toggling change tracking or show option ON/OFF - clean > Und

Re: Bug 83260

2017-12-26 Thread Yemelyanenko Fyodor
o Fyodor" Кому: "libreoffice@lists.freedesktop.org" Отправлено: 22.12.2017 16:56:53 Тема: Bug 83260 >Hello! > >I'm working on bug 83260 >(https://bugs.documentfoundation.org/show_bug.cgi?id=83260) and have an >issue... >In short, when redlining (change tracking

Bug 83260

2017-12-22 Thread Yemelyanenko Fyodor
Hello! I'm working on bug 83260 (https://bugs.documentfoundation.org/show_bug.cgi?id=83260) and have an issue... In short, when redlining (change tracking) is ON undo will crush LO during some circumstances. This is connected with redlining implementation in LO. When you toggle Show in