Re: Broken Python unit test load_save_test.py need help to finish the fix

2019-02-13 Thread Michael Stahl
On 12.02.19 15:07, Hamish MB via LibreOffice wrote: Hi, I did replace the strings, but it still doesn't work for reasons I don't understand. Is it definitely not useful to fix this and keep it around? well i've removed it now on master in commit 4bbb0bcb88614d3ccaaab4bea4fe2309c92b881e "sw: r

Re: Broken Python unit test load_save_test.py need help to finish the fix

2019-02-12 Thread Hamish MB via LibreOffice
Hi, I did replace the strings, but it still doesn't work for reasons I don't understand. Is it definitely not useful to fix this and keep it around? Hamish On 12/02/2019 13:06, Michael Stahl wrote: > On 12.02.19 13:42, Hamish MB via LibreOffice wrote: >> I found a broken and disabled test while

Re: Broken Python unit test load_save_test.py need help to finish the fix

2019-02-12 Thread Michael Stahl
On 12.02.19 13:42, Hamish MB via LibreOffice wrote: I found a broken and disabled test while doing so - load_save_test.py. I have started an attempt to fix it, and fixed several issues, but I reached a roadblock when my knowledge of pyUNO and UNO wasn't enough to finish it. The results of the wor

Broken Python unit test load_save_test.py need help to finish the fix

2019-02-12 Thread Hamish MB via LibreOffice
Hello, In January I was working on the python units tests and making them more pythonic as per the easy hack at https://bugs.documentfoundation.org/show_bug.cgi?id=97361. I found a broken and disabled test while doing so - load_save_test.py. I have started an attempt to fix it, and fixed sever