Re: Brackets are not handled correctly with mixed English/Latin and Hebrew/Arabic texts

2016-02-23 Thread Chris Sherlock
I've always considered gerrit to be the place to review code! Chris Sent from my iPhone > On 23 Feb 2016, at 4:36 PM, Khaled Hosny wrote: > > The patch does not really fix the issue, it makes it even worse. I think > she is just asking for pointers to further work on the issue, so > submitting

Re: Brackets are not handled correctly with mixed English/Latin and Hebrew/Arabic texts

2016-02-22 Thread Khaled Hosny
The patch does not really fix the issue, it makes it even worse. I think she is just asking for pointers to further work on the issue, so submitting a patch to gerrit might not be the best course of action. Regards, Khaled On Mon, Feb 22, 2016 at 10:21:27AM +0100, jan iversen wrote: > Hi > > Tha

Re: Brackets are not handled correctly with mixed English/Latin and Hebrew/Arabic texts

2016-02-22 Thread noseeba Al kindi
I submit the patch to gerrit and this is the link of the patch https://gerrit.libreoffice.org/#/c/22620/ regards, Nusaiba On Mon, Feb 22, 2016 at 1:21 PM, jan iversen wrote: > Hi > > Thanks for the work, but please submit the patch via gerrit. > > Take a loook at: > https://wiki.documentfoundat

Re: Brackets are not handled correctly with mixed English/Latin and Hebrew/Arabic texts

2016-02-22 Thread jan iversen
Hi Thanks for the work, but please submit the patch via gerrit. Take a loook at: https://wiki.documentfoundation.org/Development/GetInvolved rgds jan i. Sent from my iPad, please excuse any misspellings > On 22 Feb 2016, at 08:10, noseeba Al kindi wrote: > > Hi, > > I add some changes in

Re: Brackets are not handled correctly with mixed English/Latin and Hebrew/Arabic texts

2016-01-31 Thread Mark Hung
Hi Nusaiba, You might have to understand how layout is done. FYR: https://wiki.openoffice.org/wiki/Writer/Core_And_Layout https://wiki.openoffice.org/wiki/Writer/Text_Formatting Multiportion can contain multiple lines in one single portion. For example, SwRubyPortion is used by CJK script for asi

Brackets are not handled correctly with mixed English/Latin and Hebrew/Arabic texts

2016-01-31 Thread noseeba Al kindi
Dear, I am interested in solving this bug [56408]: https://bugs.documentfoundation.org/show_bug.cgi?id=56408 when i go through the classes there was part talking about single and multi portion that I didn't understand it, so if anyone could explain what is a portion exactly? and what is the the