Re: [PATCH]BUG#55846 Comboboxes aren’t displayed when the toolbar is vertical

2013-04-19 Thread Eike Rathke
Hi Janit, On Wednesday, 2013-04-10 00:42:49 +0530, Janit Anjaria wrote: > I am hereby attaching my bug after making all the needed changes : I fail to see where this patch actually changes code (except two cases) and not just spacing or ordering of variables. If it was meant as an additional pat

Re: [PATCH]BUG#55846 Comboboxes aren’t displayed when the toolbar is vertical

2013-04-09 Thread Janit Anjaria
Hey! I am hereby attaching my bug after making all the needed changes : *I have removed all the unnecessary changes i had made to the code,i.e. i did undo all the useless changes i had made to the code,thereby cleaning up the code. *removed the command that gave the output : debug: max width 78 deb

Re: [PATCH]BUG#55846 Comboboxes aren’t displayed when the toolbar is vertical

2013-04-08 Thread Janit Anjaria
Hey Thorsten,Stefan , I just saw the patch,yes it definitely need clean up based on the white spaces ,and yeah the numbers in the patch are added so that the UI fixes right and hence the toolbar appears to be right.I am not sure about the reason why the icons dont appear in your case,as it does ap

Re: [PATCH]BUG#55846 Comboboxes aren’t displayed when the toolbar is vertical

2013-04-08 Thread Thorsten Behrens
Janit Anjaria wrote: > I am hereby submitting my patch for review on the bug/feature which i had > worked long back which solves the problem where the comboboxes now do > appear when the toolbar is vertical. > Hi Janit, the patch contains a lot of changes ala if ( eAlign == WINDOWALIGN_TOP

Re: [PATCH]BUG#55846 Comboboxes aren’t displayed when the toolbar is vertical

2013-04-08 Thread Stefan Knorr
Hi Janit, first: I am not a developer, so don't expect code pointers here, but I tried your patch out of interest. While it does build, your patch doesn't seem to work well: * my LibreOffice window now shows no toolbar icons whatsoever * I get lots of messages à la debug: max width 38

[PATCH]BUG#55846 Comboboxes aren’t displayed when the toolbar is vertical

2013-04-08 Thread Janit Anjaria
Hey! I am hereby submitting my patch for review on the bug/feature which i had worked long back which solves the problem where the comboboxes now do appear when the toolbar is vertical. Regards, Janit 0001-fdo-55846-Comboboxes-weren-t-displayed-when-the-tool.patch Description: Binary data _

Re: BUG#55846 The font size and font name list doesnt appear in the vertical toolbar

2013-02-26 Thread Caolán McNamara
On Tue, 2013-02-26 at 01:07 +0530, Janit Anjaria wrote: > I am hereby sending you the patch for review. Your original patch is unfortunately quite badly mangled, you've included... a) a new file called vcl/0001-New-table-dialog-from-impress-and-draw-converted-to-patch which is surely an accidental

Re: BUG#55846

2013-02-11 Thread Jan Holesovsky
Hi Janit, Janit Anjaria píše v Po 11. 02. 2013 v 12:22 +0530: > I have coded the concept patch for the bug but UX has been a trouble > which i have been playing with since a little time.The Red BOX shows > that i need to expand that part of the toolbar so that the "arrow" for > the scroll can be

Re: BUG#55846

2013-02-05 Thread Jan Holesovsky
Hi Janit, Janit Anjaria píše v Út 05. 02. 2013 v 21:01 +0530: > I just completed the concept patch for BUG #55846 , and hence the code > makes the font size to produce a drop down. Great - can you please send the patch for review? Either to gerrit, or just attach to your mail, like des

Re: BUG#55846

2013-02-05 Thread Janit Anjaria
Hey! I just completed the concept patch for BUG #55846 , and hence the code makes the font size to produce a drop down. I played around with the UX quite a lot so as to fix it but i dont find a loop hole in it. Any help is appreciated. Regards, Janit On Mon, Feb 4, 2013 at 8:22 PM, Janit

Re: BUG#55846

2013-02-04 Thread Janit Anjaria
Hey! I wanted to know if someone can tell me what are some key features which libreofice needs and they are pretty cool for Impress so i can contribute under mentorship! Regards, Janit On Mon, Feb 4, 2013 at 6:45 PM, Jan Holesovsky wrote: > Hi Janit, > > Janit Anjaria píše v Ne 03. 02. 2013 v

Re: BUG#55846

2013-02-04 Thread Jan Holesovsky
Hi Janit, Janit Anjaria píše v Ne 03. 02. 2013 v 00:47 +0530: > I have fixed the bug but the UX is still a problem,i am trying my > best, Great, congrats! :-) > and it would be great if you could provide some help from your end > too. Best is not to leave out the mailing list from CC - please

Re: BUG#55846

2013-02-01 Thread Jan Holesovsky
Hi Janit, Janit Anjaria píše v Pá 01. 02. 2013 v 01:57 +0530: > I have been working on this bug and followed the code pointers,but > havent been able to figure out the loop-hole,can someone provide some > other help,except that provided on BUGZILLA I've added a comment pointing directly to the c

BUG#55846

2013-01-31 Thread Janit Anjaria
I have been working on this bug and followed the code pointers,but havent been able to figure out the loop-hole,can someone provide some other help,except that provided on BUGZILLA Regards, Janit ___ LibreOffice mailing list LibreOffice@lists.freedesktop