[WONTFIX properly] Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

2023-10-23 Thread Julien Nabet
Thank you for the feedback, I added it on https://wiki.documentfoundation.org/Development/stuck_stuff.

Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

2023-10-23 Thread Heiko Tietze
With alias I had TargetURL in mind (sorry for the confusion). For example, the command .uno:ViewTrackChanges runs actually .uno:ShowTrackedChanges. OpenPGP_signature.asc Description: OpenPGP digital signature

Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

2023-10-23 Thread Thorsten Behrens
Hi! Heiko Tietze wrote: > The typo is there for more than twenty years and macros may depend on it. > > Can we change the label but add an alias to the new "unchain" command, flag > this alias as deprecated, and remove it with the next release? > Adding an alias, and cleaning up our code sounds

Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

2023-10-23 Thread Julien Nabet
The typo is there for more than twenty years and macros may depend on it. Are we sure macros which used "UnhainFrame" were working? I mean here are the uses of "UnchainFrame": bin/find-can-be-private-symbols.functions.results:12898:SwFlyFrame::UnchainFrames(SwFlyFrame*, SwFlyFrame*) sw/source/

Re: About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

2023-10-22 Thread Heiko Tietze
The typo is there for more than twenty years and macros may depend on it. Can we change the label but add an alias to the new "unchain" command, flag this alias as deprecated, and remove it with the next release? On 22.10.23 22:49, Julien Nabet wrote: Hello, Olivier spotted a typo in UNO com

About tdf#157884 Typo in UNO command ".uno:UnhainFrame"

2023-10-22 Thread Julien Nabet
Hello, Olivier spotted a typo in UNO command ".uno:UnhainFrame", can it be fixed or is this another thing to add in https://wiki.documentfoundation.org/Development/stuck_stuff ? Here's the patch https://gerrit.libreoffice.org/c/core/+/158328 waiting for review so you'll see what it impacts (