Re: [PUSHED] Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-24 Thread Jan Holesovsky
Hi Julien, Michael Meeks píše v Pá 24. 02. 2012 v 10:15 +: > > Can I put the tracker to RESOLVED/FIXED or should I wait 3.5.1 to be > > released with the fix to change the status ? > > Sure - I'd resolve it fixed, and put a comment that it should be in > 3.5.1. Actually - changing it

Re: [PUSHED] Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-24 Thread Michael Meeks
On Thu, 2012-02-23 at 11:12 -0800, julien2412 wrote: > Can I put the tracker to RESOLVED/FIXED or should I wait 3.5.1 to be > released with the fix to change the status ? Sure - I'd resolve it fixed, and put a comment that it should be in 3.5.1. Thanks ! Michael.

[PUSHED] Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread julien2412
Pushed on master (commit bad98a1aa71e1a76c6ca4033f82168fe5b098b64). Can I put the tracker to RESOLVED/FIXED or should I wait 3.5.1 to be released with the fix to change the status ? Julien. -- View this message in context: http://nabble.documentfoundation.org/About-fdo-46339-Query-Wizard-fails

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread Michael Meeks
On Thu, 2012-02-23 at 08:35 -0800, julien2412 wrote: > What about 3.5 ? Is it ok to push it too ? Looks to me like kendy signed it off for 3-5 ;-) if not I did. Thanks for helping out with the bug fixing ! Regards, Michael. -- michael.me...@suse.com <

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread Caolán McNamara
On Thu, 2012-02-23 at 08:35 -0800, julien2412 wrote: > Thank you Jan and Caolan, I'll commit+push it on master tonight after my day > work. > > What about 3.5 ? Is it ok to push it too ? Push it to master and I'll cherry-pick it for 3-5 C. ___ LibreOf

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread julien2412
Thank you Jan and Caolan, I'll commit+push it on master tonight after my day work. What about 3.5 ? Is it ok to push it too ? Julien. -- View this message in context: http://nabble.documentfoundation.org/About-fdo-46339-Query-Wizard-fails-to-open-tp3768030p3770252.html Sent from th

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread Jan Holesovsky
Hi Caolán, Julien, On 2012-02-23 at 15:10 +, Caolán McNamara wrote: > > https://bugs.freedesktop.org/show_bug.cgi?id=46339#c6 > > I tested, just made the Wizard Query window appear (not more), both worked. > > > > I don't know which solution is good or perhaps both are wrong and it should >

Re: About fdo#46339 Query Wizard fails to open, (post fdo#42543 fix?)

2012-02-23 Thread Caolán McNamara
On Wed, 2012-02-22 at 14:09 -0800, julien2412 wrote: > Hello, > > I took a look on this bug and let some comments. Now I propose 2 ways (which > are quite the same) to solve it here : > https://bugs.freedesktop.org/show_bug.cgi?id=46339#c6 > I tested, just made the Wizard Query window appear (not

About fdo#46339 Query Wizard fails to open

2012-02-22 Thread julien2412
od or perhaps both are wrong and it should be another way, so I'd like your opinion. Julien. PS : if ok I can commit and push on master but what about 3.5 branch ? -- View this message in context: http://nabble.documentfoundation.org/About-fdo-46339-Query-Wizard-fails-to-open-tp3768030p3768030