Caolán McNamara wrote
> Pushed the agreed fix (I agree too) and updated coverity.
Thank you Caolán! One additional fix on LO and one coverity scan report less
to deal :-)
Julien
--
View this message in context:
http://nabble.documentfoundation.org/About-coverity-705746-pormulti-cxx-from-sw-mo
On Fri, 2013-03-15 at 13:11 +0200, Noel Grandin wrote:
> On 2013-03-15 12:03, julien2412 wrote:
> > Oups, I was wrong , if they're not exclusive, "new" line is required for
> > each
> > block
> >
> > Sorry Noël and Riccardo for the noise. Can you push a patch about this and
> > update coverity?
>
On 2013-03-15 12:03, julien2412 wrote:
Oups, I was wrong , if they're not exclusive, "new" line is required for each
block
Sorry Noël and Riccardo for the noise. Can you push a patch about this and
update coverity?
If not, I'll do it but only during week-end because I won't have much time.
Thank
Oups, I was wrong , if they're not exclusive, "new" line is required for each
block
Sorry Noël and Riccardo for the noise. Can you push a patch about this and
update coverity?
If not, I'll do it but only during week-end because I won't have much time.
Thank you for having very patiently answered t
Il 15/03/2013 10:13, Julien ha scritto:
If nLeft and nRight are exlusive, it could also just be an if(nLeft)... else...
They are not, Noel code is correct
riccardo
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedeskto
De : Noel Grandin
À : julien2412
Cc : libreoffice@lists.freedesktop.org
Envoyé le : Vendredi 15 mars 2013 10h04
Objet : Re: About coverity 705746 (pormulti.cxx from sw module)
On 2013-03-15 10:30, julien2412 wrote:
Noel Grandin wrote
>I would guess that someone meant to move line
On 2013-03-15 10:30, julien2412 wrote:
Noel Grandin wrote
I would guess that someone meant to move line 742 inside the first "if"
statement, but only did half the job.
Hello Noël,
Perhaps I'm too sleepy this morning but I don't see the interest to
duplicate the "new" part. Any hint?
I thin
Hello,
Il 15/03/2013 09:30, julien2412 ha scritto:
Noel Grandin wrote
I would guess that someone meant to move line 742 inside the first "if"
statement, but only did half the job.
Hello Noël,
Perhaps I'm too sleepy this morning but I don't see the interest to
duplicate the "new" part. Any hi
Noel Grandin wrote
> I would guess that someone meant to move line 742 inside the first "if"
> statement, but only did half the job.
Hello Noël,
Perhaps I'm too sleepy this morning but I don't see the interest to
duplicate the "new" part. Any hint?
Julien
--
View this message in context:
h
On 2013-03-14 21:20, julien2412 wrote:
Hello,
Scan coverity detected this:
27. overwrite_var: Overwriting "pMarg" in "pMarg = new SwMarginPortion(0)"
leaks the storage that "pMarg" points to
(http://opengrok.libreoffice.org/xref/core/sw/source/core/text/pormulti.cxx#738)
738 if( nLeft
Hello,
Scan coverity detected this:
27. overwrite_var: Overwriting "pMarg" in "pMarg = new SwMarginPortion(0)"
leaks the storage that "pMarg" points to
(http://opengrok.libreoffice.org/xref/core/sw/source/core/text/pormulti.cxx#738)
738 if( nLeft || nRight )
739 {
740
11 matches
Mail list logo
