Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread julien2412
The following discussion is interesting but shows that it's not a quick and/or easy fix for casual contributor like me. So I let the experts keep on about this and determine if there's something to change or not. Thank you for your feedback about this Michael, Tor and Matúš Julien -- View this

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Tor Lillqvist
> Only c++ components have prefixes. Sure, and what this code does is load a native (C++) library (component). > and still not all off them, > stoc/util/bootstrap.component is one of the last(if not the last), a > little more complicated. Hmm, indeed, so maybe this code is intended then to load

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Matúš Kukan
On 12 March 2013 20:41, Tor Lillqvist wrote: >> http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) > > I wonder if that native method actually gets used. If it does, it is > to load 3rd-party native UNO components (in extensions) from Java, as > all our own UNO c

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Tor Lillqvist
> That native > com.sun.star.comp.helper.SharedLibraryLoader.component_getFactory() > method doesn't take any prefix argument, it always looks for a symbol > called exactly "component_getFactory". Forgot to mention, first it looks for a symbol called "component_getImplementationEnvironment", no p

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Tor Lillqvist
> http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) I wonder if that native method actually gets used. If it does, it is to load 3rd-party native UNO components (in extensions) from Java, as all our own UNO components use a prefix, don't they? That native com.s

Re: About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread Michael Meeks
Hi there, On Tue, 2013-03-12 at 12:21 -0700, julien2412 wrote: > leaked_storage: Variable "lib" going out of scope leaks the storage it > points to. line 236 > (see > http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) > I just thought adding > osl_unloadModule(l

About coverity 705665 (javaunohelper.cxx)

2013-03-12 Thread julien2412
Hello, Scan coverity detected this: leaked_storage: Variable "lib" going out of scope leaks the storage it points to. line 236 (see http://opengrok.libreoffice.org/xref/core/javaunohelper/source/javaunohelper.cxx#236) I just thought adding osl_unloadModule(lib) just before line 235, so last line