Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Eike Rathke
Hi Kevin, On Wednesday, 2012-02-29 15:38:30 +0100, Kevin André wrote: > >>      return ((nYear % 4) == 0) > >> -        && !(((nYear % 100) == 0) || ((nYear % 400) == 0)); > >> +        && (((nYear % 100) != 0) || ((nYear % 400) == 0)); > > Why still that many parentheses? Couldn't it be simply:

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Kevin André
On Wed, Feb 29, 2012 at 18:07, Lionel Elie Mamane wrote: > On Wed, Feb 29, 2012 at 03:38:30PM +0100, Kevin André wrote: >> On Wed, Feb 29, 2012 at 14:56, Lionel Elie Mamane wrote: >>> On Tue, Feb 28, 2012 at 10:10:10PM -0500, Kohei Yoshida wrote: >      return ((nYear % 4) == 0) -      

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Lionel Elie Mamane
On Wed, Feb 29, 2012 at 03:38:30PM +0100, Kevin André wrote: > On Wed, Feb 29, 2012 at 14:56, Lionel Elie Mamane wrote: >> On Tue, Feb 28, 2012 at 10:10:10PM -0500, Kohei Yoshida wrote: >>>      return ((nYear % 4) == 0) >>> -        && !(((nYear % 100) == 0) || ((nYear % 400) == 0)); >>> +      

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Kevin André
On Wed, Feb 29, 2012 at 14:56, Lionel Elie Mamane wrote: > On Tue, Feb 28, 2012 at 10:10:10PM -0500, Kohei Yoshida wrote: > >> From 0666b5dca1a210ce7abc61a522a59c48661fe664 Mon Sep 17 00:00:00 2001 >> From: Kohei Yoshida >> Date: Tue, 28 Feb 2012 22:01:52 -0500 >> Subject: [PATCH] Correctly calcu

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Lionel Elie Mamane
On Tue, Feb 28, 2012 at 10:10:10PM -0500, Kohei Yoshida wrote: > From 0666b5dca1a210ce7abc61a522a59c48661fe664 Mon Sep 17 00:00:00 2001 > From: Kohei Yoshida > Date: Tue, 28 Feb 2012 22:01:52 -0500 > Subject: [PATCH] Correctly calculate leap year. > With the old code, year 2000 would not be a le