Re: [REVIEW 3-5] lp#818761: Remove SalDisplay::GetKeyboardName

2012-04-26 Thread Michael Meeks
On Thu, 2012-04-26 at 00:46 +0200, Bjoern Michaelsen wrote: > I just adjusted 04b9c2f633f0be1b676933943bdd0b1dc58b5471 from master for > cherry-pick on -3-5 because it removes code that causes this crasher: > https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/818761 > > you will find the

Re: [REVIEW 3-5] lp#818761: Remove SalDisplay::GetKeyboardName

2012-04-26 Thread Bjoern Michaelsen
On Thu, Apr 26, 2012 at 12:46:49AM +0200, Bjoern Michaelsen wrote: > https://gerrit.libreoffice.org/#/c/104/ Ok, just for fun I updated the patch according to Norberts nitpicks. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.o

Re: [REVIEW 3-5] lp#818761: Remove SalDisplay::GetKeyboardName

2012-04-26 Thread Bjoern Michaelsen
On Thu, Apr 26, 2012 at 08:13:07AM +0200, Thomas Arnhold wrote: > to answer Norbert's question about signalKeysChanged - this was > removed with: 9a7605b8f08dfcfbc99bc0c635014eac8e41e932 Yes, commented inline. You can do the same next time, logging in isnt too hard (OpenID so no registering ;) ).

Re: [REVIEW 3-5] lp#818761: Remove SalDisplay::GetKeyboardName

2012-04-25 Thread Thomas Arnhold
Hi Bjoern, to answer Norbert's question about signalKeysChanged - this was removed with: 9a7605b8f08dfcfbc99bc0c635014eac8e41e932 Thomas On 04/26/2012 12:46 AM, Bjoern Michaelsen wrote: Hi there, I just adjusted 04b9c2f633f0be1b676933943bdd0b1dc58b5471 from master for cherry-pick on -3-5 be

[REVIEW 3-5] lp#818761: Remove SalDisplay::GetKeyboardName

2012-04-25 Thread Bjoern Michaelsen
Hi there, I just adjusted 04b9c2f633f0be1b676933943bdd0b1dc58b5471 from master for cherry-pick on -3-5 because it removes code that causes this crasher: https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/818761 you will find the fixed-up patch at: https://gerrit.libreoffice.org/#/c/10