Re: [REVIEW 3-5] fdo#49208 ridiculous performance on certain .doc

2012-05-02 Thread Caolán McNamara
On Tue, 2012-05-01 at 22:26 +0200, Muhammad Haggag wrote: > Is it OK to break Unicode equivalence > (http://en.wikipedia.org/wiki/Unicode_equivalence) by doing a memory > comparison? Yeah, because the existing code doesn't pay any attention to stuff like that. Presumably we wave a magic wand somew

Re: [REVIEW 3-5] fdo#49208 ridiculous performance on certain .doc

2012-05-01 Thread Muhammad Haggag
On Tue, May 1, 2012 at 5:43 PM, Caolán McNamara wrote: > icu's string compare is very very slow when you just want to check for > equality > http://cgit.freedesktop.org/libreoffice/core/commit/?id=ccc47b3db3eae25cc11bb709416c0b61747ca89e > Is it OK to break Unicode equivalence (http://en.wikipedia

[REVIEW 3-5] fdo#49208 ridiculous performance on certain .doc

2012-05-01 Thread Caolán McNamara
The .doc has some paragraphs in it that are around the 64k length mark. It doesn't *look* like that's the case because they end in vast quantity of whitespace and writer implements the word-compatibility thing to let empty spaces disappear off the right side of the page rather than wrap. Turns out