Re: [REVIEW 3-5][PATCH] Re: librO python & ssl support

2012-04-17 Thread Caolán McNamara
On Tue, 2012-04-10 at 16:33 +0100, Caolán McNamara wrote: > On Tue, 2012-04-10 at 16:14 +0100, Caolán McNamara wrote: > > Now proposing the above commit for 3-5. > > Rats, macosx buildbot tells me that our internal expat, which is now > picked up instead of the system macosx expat, is missing > _X

Re: [REVIEW 3-5][PATCH] Re: librO python & ssl support

2012-04-10 Thread Stephan Bergmann
On 04/10/2012 05:14 PM, Caolán McNamara wrote: On Fri, 2012-04-06 at 12:56 +0200, Laurent Godard wrote: why in python_LDFLAGS do we use /usr/lib and not /usr$/lib as on other lines. is it important ? does it make any difference ? Probably an oversight $/ used to expand to \ for Windows 4NT s

Re: [REVIEW 3-5][PATCH] Re: librO python & ssl support

2012-04-10 Thread Caolán McNamara
On Tue, 2012-04-10 at 16:14 +0100, Caolán McNamara wrote: > Now proposing the above commit for 3-5. Rats, macosx buildbot tells me that our internal expat, which is now picked up instead of the system macosx expat, is missing _XML_SetAttlistDeclHandler or some such at link time C. __

Re: [REVIEW 3-5][PATCH] Re: librO python & ssl support

2012-04-10 Thread Caolán McNamara
On Fri, 2012-04-06 at 12:56 +0200, Laurent Godard wrote: > i had a look and here is the patch i deduced. may be wrong as makefile > things are a bit cryptic to me ;) Tweaked it a bit and seems to work here, I get the expected results from ldd http://cgit.freedesktop.org/libreoffice/core/commit/?i