Re: [REVIEW-3.5] crasher fdo#45987

2012-05-18 Thread Markus Mohrhard
Hello Noel, Kohei, I think [1] is a better patch for 3-5. I'm still not happy with it because I had hoped that we could init the number of sheets already in the constructor but this works only while loading a file and not when we create an empty one. This hack is a bit dirty but was the only usefu

Re: [REVIEW-3.5] crasher fdo#45987

2012-05-18 Thread Noel Power
On 18/05/12 14:49, Markus Mohrhard wrote: Hey Noel 2012/5/18 Kohei Yoshida: On Fri, May 18, 2012 at 9:14 AM, Noel Power wrote: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b1d29bc9b00bc2730738a990023a65ab6e0219b & http://cgit.freedesktop.org/libreoffice/core/commit/?id=abb26f51e

Re: [REVIEW-3.5] crasher fdo#45987

2012-05-18 Thread Markus Mohrhard
Hey Noel 2012/5/18 Kohei Yoshida : > On Fri, May 18, 2012 at 9:14 AM, Noel Power wrote: > >>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b1d29bc9b00bc2730738a990023a65ab6e0219b >>> & >>> >>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=abb26f51eea0399754cc8f5b7d7a7d648d68

Re: [REVIEW-3.5] crasher fdo#45987

2012-05-18 Thread Kohei Yoshida
On Fri, May 18, 2012 at 9:14 AM, Noel Power wrote: >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b1d29bc9b00bc2730738a990023a65ab6e0219b >> & >> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=abb26f51eea0399754cc8f5b7d7a7d648d68f630 > > > I took it that it should work ho

Re: [REVIEW-3.5] crasher fdo#45987

2012-05-18 Thread Noel Power
On 18/05/12 10:31, Noel Power wrote: On 18/05/12 10:26, Noel Power wrote: Hi somewhat of a containing fix ( I think there is other rework needed, see below ) that avoids the mentioned crasher, please consider cherry-picking to 3.5 Always ( afaict ) the code expects the index of the entry in

Re: [REVIEW-3.5] crasher fdo#45987

2012-05-18 Thread Noel Power
On 18/05/12 10:26, Noel Power wrote: Hi somewhat of a containing fix ( I think there is other rework needed, see below ) that avoids the mentioned crasher, please consider cherry-picking to 3.5 Always ( afaict ) the code expects the index of the entry in the (maTabs) vector to correspond a t

[REVIEW-3.5] crasher fdo#45987

2012-05-18 Thread Noel Power
Hi somewhat of a containing fix ( I think there is other rework needed, see below ) that avoids the mentioned crasher, please consider cherry-picking to 3.5 Always ( afaict ) the code expects the index of the entry in the (maTabs) vector to correspond a tab of the same index. However the Del