Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS

2012-07-23 Thread Norbert Thiebaud
On Mon, Jul 23, 2012 at 9:48 AM, Thorsten Behrens wrote: > Jan Holesovsky wrote: >> Thanks so much for that! - looks great to me; we should probably remove >> the AquaSalGraphics::GetGlyphBoundRect() so that it does not confuse >> others too, right? :-) >> > No idea - Norbert, you were refactoring

Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS

2012-07-23 Thread Norbert Thiebaud
On Mon, Jul 23, 2012 at 10:06 AM, Norbert Thiebaud wrote: > On Mon, Jul 23, 2012 at 9:48 AM, Thorsten Behrens > wrote: >> Jan Holesovsky wrote: >>> Thanks so much for that! - looks great to me; we should probably remove >>> the AquaSalGraphics::GetGlyphBoundRect() so that it does not confuse >>>

Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS

2012-07-23 Thread Thorsten Behrens
Michael Meeks wrote: > +1 from me - it simply duplicates the equivalent code [cough] from > DrawText - right ? ;-) > Yes. ;) -- Thorsten pgpglEapxrvtB.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS

2012-07-23 Thread Thorsten Behrens
Jan Holesovsky wrote: > Thanks so much for that! - looks great to me; we should probably remove > the AquaSalGraphics::GetGlyphBoundRect() so that it does not confuse > others too, right? :-) > No idea - Norbert, you were refactoring that recently, any opinion? -- Thorsten pgpZi7zv0NYgd.pgp Des

Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS

2012-07-23 Thread Michael Meeks
On Mon, 2012-07-23 at 15:53 +0200, Jan Holesovsky wrote: > > would some two people please review & then cherry-pick > > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5bfba6ee21b5576c9da475b13d7db0f735f078d2 > > Thanks so much for that! - looks great to me; we should probably remove

Re: [REVIEW-3-6-0] Fix vertical rulers on MacOS

2012-07-23 Thread Jan Holesovsky
Hi Thorsten, On 2012-07-22 at 16:42 +0200, Thorsten Behrens wrote: > would some two people please review & then cherry-pick > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5bfba6ee21b5576c9da475b13d7db0f735f078d2 > > into libreoffice-3-6-0? Thanks so much for that! - looks grea

[REVIEW-3-6-0] Fix vertical rulers on MacOS

2012-07-22 Thread Thorsten Behrens
Hi there, would some two people please review & then cherry-pick http://cgit.freedesktop.org/libreoffice/core/commit/?id=5bfba6ee21b5576c9da475b13d7db0f735f078d2 into libreoffice-3-6-0? This fixes the rather ugly https://bugs.freedesktop.org/show_bug.cgi?id=50631 , and _only_ affects MacOS