Re: [REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-03-01 Thread Noel Power
On 01/03/12 05:09, Michael Meeks wrote: Looks a bit scary for 3.5.1 after RC1 surely ? or has this been well-tested elsewhere ? I guess if so a further +1 from me, coincidently I made the same change locally > today whilst investigating a large import doc, definitely improved the > import tim

Re: [REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 22:53 +, Noel Power wrote: > and for 3-5-1 ( or is it too late ) ? Looks a bit scary for 3.5.1 after RC1 surely ? or has this been well-tested elsewhere ? > if so a further +1 from me, coincidently I made the same change locally > today whilst investigating a l

Re: [REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-02-29 Thread Noel Power
and for 3-5-1 ( or is it too late ) ? if so a further +1 from me, coincidently I made the same change locally today whilst investigating a large import doc, definitely improved the import time Noel On 29/02/12 22:09, Michael Stahl wrote: the following fixes a performance regression in OOo 3.

[REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-02-29 Thread Michael Stahl
the following fixes a performance regression in OOo 3.4; i have actually fixed this before in OOo times but the fix somehow got lost in the CWS process overhead... ah, the issue for it was this: https://issues.apache.org/ooo/show_bug.cgi?id=115684 http://cgit.freedesktop.org/libreoffice/core/com