Re: [REVIEW][3-5] fix STL assertion in vcl graphite code

2012-03-19 Thread Martin Hosken
Dear Petr, Thank you for the reminder of this issue. My apologies for not getting to it earlier. > > > > I do not understand the code either. I just wonder if it would make > > sense to check for: > > > > while (++nCharIndex - mnMinCharPos < > > static_cast(mvChar2BaseG

Re: [REVIEW][3-5] fix STL assertion in vcl graphite code

2012-03-19 Thread Petr Mladek
Petr Mladek píše v Út 06. 03. 2012 v 12:23 +0100: > Michael Stahl píše v St 29. 02. 2012 v 23:08 +0100: > > this patch fixes a STL assertion in GraphiteLayout::expandOrCondense; > > since i don't know how the multitude of arrays in there are supposed to > > be used, i thought it's probably a good i

Re: [REVIEW][3-5] fix STL assertion in vcl graphite code

2012-03-06 Thread Petr Mladek
Michael Stahl píše v St 29. 02. 2012 v 23:08 +0100: > this patch fixes a STL assertion in GraphiteLayout::expandOrCondense; > since i don't know how the multitude of arrays in there are supposed to > be used, i thought it's probably a good idea to check the size of the > array that will be indexed

[REVIEW][3-5] fix STL assertion in vcl graphite code

2012-02-29 Thread Michael Stahl
this patch fixes a STL assertion in GraphiteLayout::expandOrCondense; since i don't know how the multitude of arrays in there are supposed to be used, i thought it's probably a good idea to check the size of the array that will be indexed in the next line, as opposed to one that isn't mentioned in